Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swap buoy_all.yaml back to main #119

Merged
merged 2 commits into from
Jan 24, 2023
Merged

Swap buoy_all.yaml back to main #119

merged 2 commits into from
Jan 24, 2023

Conversation

quarkytale
Copy link
Contributor

No description provided.

@quarkytale
swap buoy_all.yaml back to main
914ea30 
Signed-off-by: Dharini Dutia <[email protected]>
@quarkytale
Copy link
Contributor Author

So pc_commands_ros_feedback is intermittently failing with

35: ======================================================================
35: FAIL: test_termination (buoy_tests.PCCommandsROSTest)
35: ----------------------------------------------------------------------
35: Traceback (most recent call last):
35:   File "/github/home/ws/src/buoy_sim/buoy_tests/launch/pc_commands_ros_feedback.launch.py", line 61, in test_termination
35:     proc_info.assertWaitForShutdown(process=gazebo_test_fixture, timeout=600)
35:   File "/opt/ros/humble/lib/python3.10/site-packages/launch_testing/proc_info_handler.py", line 141, in assertWaitForShutdown
35:     assert success, "Timed out waiting for process '{}' to finish".format(process)
35: AssertionError: Timed out waiting for process '<launch_ros.actions.node.Node object at 0x7f2c4f375690>' to finish

When I re-run the jobs individually they pass.

@mabelzhang mabelzhang linked an issue Jan 23, 2023 that may be closed by this pull request
Upgrade to Humble + Garden #81
Closed
12 tasks
@andermi
Fix flaky PC commands test (#120)
cb74bee 
* debug pc commands; turn off some noisy prints; change assert to expect

Signed-off-by: Michael Anderson <[email protected]>

* switch back to testing all

Signed-off-by: Michael Anderson <[email protected]>
@andermi
Copy link
Collaborator

andermi commented Jan 23, 2023

woot

@andermi
Copy link
Collaborator

andermi commented Jan 24, 2023

@quarkytale was there anything left to do here or can we merge?

@hamilton8415
Copy link
Collaborator

Great Dharini, let's merge this into main asap so it doesn't interfere with activities involveing merging main into branches...

@quarkytale quarkytale merged commit 3951e8c into main Jan 24, 2023
@quarkytale quarkytale deleted the humble_garden_cleanup branch January 24, 2023 06:12
@quarkytale
Copy link
Contributor Author

Sorry I thought this went in during the meeting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andermi andermi andermi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade to Humble + Garden
3 participants
@quarkytale @andermi @hamilton8415