Fix flaky PC commands test #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Anderson <[email protected]>
|
now I can't get it to fail anymore |
mabelzhang
approved these changes
Jan 23, 2023
quarkytale
added a commit
that referenced
this pull request
Jan 24, 2023
* swap buoy_all.yaml back to main Signed-off-by: Dharini Dutia <[email protected]> * Fix flaky PC commands test (#120) * debug pc commands; turn off some noisy prints; change assert to expect Signed-off-by: Michael Anderson <[email protected]> * switch back to testing all Signed-off-by: Michael Anderson <[email protected]> Signed-off-by: Dharini Dutia <[email protected]> Signed-off-by: Michael Anderson <[email protected]> Co-authored-by: andermi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed some asserts to expects which I think was causing it to bomb out early and then timeout when launch_test didn't notice it exited.