Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove default plugins from SDF worlds #12

Merged
merged 1 commit into from
Apr 18, 2022
Merged

Remove default plugins from SDF worlds #12

merged 1 commit into from
Apr 18, 2022

Conversation

chapulina
Copy link
Contributor

The SDF worlds are currently loading several world and GUI plugins which would be loaded by default anyway. We can reduce some boilerplate by just removing all plugins. We should only specify the plugins to load in case we want to load non-default plugins.

You can check that the world still work as before:

ign gazebo -v 2 mbari_wec.sdf
ign gazebo -v 2 electrohydraulicPTO.sdf
ign gazebo -v 2 pneumatic_spring.sdf

andermi
andermi approved these changes Apr 18, 2022
View reviewed changes
Copy link
Collaborator

@andermi andermi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! runs for me

@chapulina chapulina merged commit 1e07f2c into main Apr 18, 2022
@chapulina chapulina deleted the chapulina/system_plugins branch April 18, 2022 23:38
@chapulina chapulina mentioned this pull request May 11, 2022
Merged
@hamilton8415 hamilton8415 mentioned this pull request Nov 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andermi andermi andermi approved these changes

@hamilton8415 hamilton8415 Awaiting requested review from hamilton8415

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chapulina @andermi