Move world plugins to a config file #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On #12 all world plugins were removed from the world files so we could load the defaults instead. But then on #33 we needed a non-default plugin, which meant we had to add all others.
This PR moves those plugins to a
server.configfile and points to that file using theIGN_GAZEBO_SERVER_CONFIG_PATH, so that becomes the new default set of plugins. This way, buoyancy will be enabled by default for all worlds.It's still possible to override this config file by explicitly listing plugins inside each world file as needed.
There's more info about server configs on this tutorial.
Test it
Run
ign gazebo mbari_wec.sdf -rThe simulation should start and the buoy bounces up and down due to buoyancy.