Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating package maintainers #141

Merged
merged 4 commits into from
May 5, 2023
Merged

Updating package maintainers #141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c36133c
adding package maintainers and authors
quarkytale Apr 19, 2023
0ff413f
correct buoy_tests
quarkytale Apr 19, 2023
9e98c9c
Apply suggestions from code review
quarkytale Apr 21, 2023
bbe393a
increase sc test timeout
quarkytale May 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion buoy_description/package.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,16 @@
<name>buoy_description</name>
<version>0.0.0</version>
<description>Contains SDF files and meshes for the marine buoy</description>
<maintainer email="[email protected]">Louise Poubel</maintainer>

<maintainer email="[email protected]">Andrew Hamilton</maintainer>
<maintainer email="[email protected]">Dharini Dutia</maintainer>
<maintainer email="[email protected]">Mabel Zhang</maintainer>
<maintainer email="[email protected]">Michael Anderson</maintainer>

<license>Apache 2.0</license>

<author>Louise Poubel</author>
<author email="[email protected]">Michael Carroll</author>

<buildtool_depend>ament_cmake</buildtool_depend>

Expand Down
12 changes: 11 additions & 1 deletion buoy_gazebo/package.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,19 @@
<name>buoy_gazebo</name>
<version>0.0.0</version>
<description>Gazebo simulation plugins and worlds for buoy.</description>
<maintainer email="[email protected]">Louise Poubel</maintainer>

<maintainer email="[email protected]">Andrew Hamilton</maintainer>
<maintainer email="[email protected]">Dharini Dutia</maintainer>
<maintainer email="[email protected]">Mabel Zhang</maintainer>
<maintainer email="[email protected]">Michael Anderson</maintainer>

<license>Apache 2.0</license>

<author>Louise Poubel</author>
<author>Joan Aguilar Mayans</author>
<author email="[email protected]">Michael Carroll</author>
<author email="[email protected]">Rhys Mainwaring</author>
<author email="[email protected]">Robert McEwen</author>

<buildtool_depend>ament_cmake</buildtool_depend>

Expand Down
4 changes: 2 additions & 2 deletions buoy_tests/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ if(BUILD_TESTING)

if(buoy_add_gtest_LAUNCH_TEST)
add_launch_test(launch/${TEST_NAME}.launch.py
TIMEOUT 900
TIMEOUT 1000
)
else()
ament_add_gtest_test(${TEST_NAME})
Expand Down Expand Up @@ -141,7 +141,7 @@ if(BUILD_TESTING)
endif()

add_launch_test(launch/${PYTEST_NAME}_py.launch.py
TIMEOUT 900
TIMEOUT 1000
)
endfunction()

Expand Down
2 changes: 1 addition & 1 deletion buoy_tests/launch/sc_commands_ros_feedback.launch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ def generate_test_description():
class SCCommandsROSTest(unittest.TestCase):

def test_termination(self, gazebo_test_fixture, proc_info):
proc_info.assertWaitForShutdown(process=gazebo_test_fixture, timeout=900)
proc_info.assertWaitForShutdown(process=gazebo_test_fixture, timeout=1000)


@launch_testing.post_shutdown_test()
Expand Down
9 changes: 7 additions & 2 deletions buoy_tests/package.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,18 @@
<name>buoy_tests</name>
<version>0.0.0</version>
<description>Tests for buoy simulation.</description>
<maintainer email="[email protected]">Louise Poubel</maintainer>

<maintainer email="[email protected]">Andrew Hamilton</maintainer>
<maintainer email="[email protected]">Michael Anderson</maintainer>

<license>Apache 2.0</license>

<author email="[email protected]">Dharini Dutia</author>
<author>Louise Poubel</author>
<author email="[email protected]">Michael Carroll</author>

<buildtool_depend>ament_cmake</buildtool_depend>
<buildtool_depend>ament_cmake_python</buildtool_depend>

<buildtool_depend>rosidl_default_generators</buildtool_depend>

<test_depend>ament_cmake_gtest</test_depend>
Expand Down