Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating package maintainers #141

Merged
merged 4 commits into from
May 5, 2023
Merged

Updating package maintainers #141

merged 4 commits into from
May 5, 2023

Conversation

quarkytale
Copy link
Contributor

Apologies if I missed or miscredited anyone 🙏

Added maintainers and authors in alphabetical order, depending on contributors of each package (or rather everyone should be added in every package?).

Notes:

  • Need Louise's and Joan's current/preferred email
  • Added Rob in buoy_gazebo to credit for mbari_wec

@quarkytale quarkytale linked an issue Apr 19, 2023 that may be closed by this pull request
Signed-off-by: Dharini Dutia <[email protected]>
@quarkytale quarkytale marked this pull request as ready for review April 19, 2023 03:08
Copy link
Collaborator

@mabelzhang mabelzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine to have the author tags without emails. Since they're not maintainers, people shouldn't be bothering them anyway.

buoy_description/package.xml Outdated Show resolved Hide resolved
buoy_gazebo/package.xml Outdated Show resolved Hide resolved
buoy_tests/package.xml Outdated Show resolved Hide resolved
Copy link
Collaborator

@mabelzhang mabelzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Feel free to merge unless there's dissent - can always correct later.

@quarkytale

This comment was marked as outdated.

@quarkytale quarkytale enabled auto-merge (squash) April 27, 2023 20:52
@quarkytale
Copy link
Contributor Author

SC Commands test keeps timing out here which seems unrelated to the changes in this PR. @andermi any suggestions?
Test #37: launch_sc_commands_ros_feedback.launch.py ...***Timeout 900.11 sec

@andermi
Copy link
Collaborator

andermi commented May 3, 2023 via email

@quarkytale quarkytale force-pushed the update_maintainers branch 3 times, most recently from 4535f59 to aaef202 Compare May 4, 2023 20:23
Signed-off-by: Dharini Dutia <[email protected]>
@quarkytale
Copy link
Contributor Author

@andermi set the timeouts to nothing less than 1000 sec works well, is it okay if I get this in and further refinements can be done in a separate PR if required?

@andermi
Copy link
Collaborator

andermi commented May 5, 2023

Yep fine with me! Merge away!

@quarkytale quarkytale merged commit 55c7a64 into main May 5, 2023
@quarkytale quarkytale deleted the update_maintainers branch May 5, 2023 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update maintainers
3 participants