-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating package maintainers #141
Conversation
Signed-off-by: Dharini Dutia <[email protected]>
Signed-off-by: Dharini Dutia <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's fine to have the author tags without emails. Since they're not maintainers, people shouldn't be bothering them anyway.
Co-authored-by: Mabel Zhang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Feel free to merge unless there's dissent - can always correct later.
This comment was marked as outdated.
This comment was marked as outdated.
SC Commands test keeps timing out here which seems unrelated to the changes in this PR. @andermi any suggestions? |
Increase the timeouts. It’s a long test on a very slow machine. I’ve had to increase the timeouts a few times now. I think their machines are getting even slower…
|
4535f59
to
aaef202
Compare
Signed-off-by: Dharini Dutia <[email protected]>
aaef202
to
bbe393a
Compare
@andermi set the timeouts to nothing less than 1000 sec works well, is it okay if I get this in and further refinements can be done in a separate PR if required? |
Yep fine with me! Merge away! |
Apologies if I missed or miscredited anyone 🙏
Added maintainers and authors in alphabetical order, depending on contributors of each package (or rather everyone should be added in every package?).
Notes:
mbari_wec