feat(python): #7476 - Support Python 3.11 #7533

mawl · 2023-09-19T09:36:44Z

Fix issue #7476 - Support Python 3.11

Python 3.11 is supported by python-inspector already: aboutcode-org/python-inspector@8c6ee63

As it is my first PR in your project, feel free to correct it and get me on the right track.

sschuberth

Please rewrite commit messages to adhere to Conventional Commits, and capitalize proper nouns like "Python".

plugins/package-managers/python/src/main/kotlin/Pip.kt

Dockerfile

codecov · 2023-09-19T10:10:24Z

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (49bf674) 68.03% compared to head (f2e8e91) 68.03%.

Additional details and impacted files

@@            Coverage Diff            @@
##               main    #7533   +/-   ##
=========================================
  Coverage     68.03%   68.03%           
  Complexity     2022     2022           
=========================================
  Files           344      344           
  Lines         16723    16723           
  Branches       2370     2370           
=========================================
  Hits          11377    11377           
  Misses         4363     4363           
  Partials        983      983

Flag	Coverage Δ
funTest-non-docker	`36.44% <ø> (ø)`
test	`35.53% <ø> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mawl · 2023-09-26T06:09:39Z

@sschuberth: Thanks for your support. I have squashed the commits and upgraded the relevant tools (python, pyenv and poetry). Tests are green now. Is there anything else I can do or can we merge it now?

sschuberth · 2023-09-26T06:10:03Z

@mawl by now the commit diff doesn't seem to match the commit message anymore, as only the Poetry version is bumped.

mawl · 2023-09-26T06:11:44Z

@mawl by now the commit diff doesn't seem to match the commit message anymore, as only the Poetry version is bumped.

I squashed too much and the changes are gone. I'll take a look.

mawl · 2023-09-26T06:20:25Z

@mawl by now the commit diff doesn't seem to match the commit message anymore, as only the Poetry version is bumped.

Changes are back now.

Currently Python 3.11 isn't in the list of available Python versions. This commit extends the list of versions and sets 3.11 as default version. + Update versions of Python tools: * Python 3.10.8 to 3.11.4 * Pyenv v2.3.7 to v2.3.27 to have Python 3.11.4 environment available * Poetry 1.2.2 to 1.6.1 to fix oss-review-toolkit#7333 Signed-off-by: mawl <[email protected]>

Comments addressed.

sschuberth · 2023-09-26T06:31:39Z

I'm basically ok with the changes, but I'm not in a position to judge whether this would break things for people at Bosch or EPAM. So I'd prefer @mnonnenmacher / @MarcelBochtler and @fviernau to have a look.

mnonnenmacher · 2023-09-26T08:07:37Z

Dockerfile

@@ -138,7 +138,7 @@ RUN curl -kSs https://pyenv.run | bash \
 ARG CONAN_VERSION=1.57.0
 ARG PYTHON_INSPECTOR_VERSION=0.9.8
 ARG PYTHON_PIPENV_VERSION=2022.9.24
-ARG PYTHON_POETRY_VERSION=1.2.2
+ARG PYTHON_POETRY_VERSION=1.6.1


Please upgrade the Poetry version in Dockerfile-legacy as well. Dockerfile-legacy is used by CI, maybe that is related to the failing tests.

@mnonnenmacher: I hope you are fine with changing python-inspector to 0.9.8 as well, as this will resolve: #7333 (comment)

Yes please, versions should in general stay in sync. Installing Python 3.11 would be more difficult with the legacy file, so I think it's fine to stay with the default 3.10 there. python-inspector should still support 3.11 as long as no setup.py file which depends on 3.11 is involved.

mnonnenmacher · 2023-09-26T08:20:29Z

I'm basically ok with the changes, but I'm not in a position to judge whether this would break things for people at Bosch or EPAM. So I'd prefer @mnonnenmacher / @MarcelBochtler and @fviernau to have a look.

We use the Dockerfile-legacy so the Python version upgrade would not affect us. Changing the default version used by python-inspector should be fine as it is easy to configure the version to be used.

Update Dockerfile-legacy * python-inspector from 0.9.6 to 0.9.8 * poetry from 1.2.2 to 1.6.1 Both updates are necessary to fix oss-review-toolkit#7333 and the CI pipeline Signed-off-by: mawl <[email protected]>

heliocastro · 2023-09-26T19:55:11Z

With the new docker merged, all version changes should be done in one single place, .versions
So both Docker, Docker extended and the local docker_build script will know how to build or not the modified image.

Signed-off-by: mawl <[email protected]>

heliocastro · 2023-09-28T08:18:34Z

Please modify the .versions file as well

Update Python from 3.10.13 to 3.11.4 Update Pyenv from v2.3.25 to v2.3.27 Signed-off-by: mawl <[email protected]>

heliocastro

Looks good to me

sschuberth

We do not allow merge commits in PRs.

sschuberth · 2023-09-28T09:49:31Z

Dockerfile

@@ -126,8 +126,8 @@ RUN --mount=type=cache,target=/var/cache/apt,sharing=locked \
    tk-dev \
    && sudo rm -rf /var/lib/apt/lists/*

-ARG PYTHON_VERSION=3.10.8
-ARG PYENV_GIT_TAG=v2.3.7
+ARG PYTHON_VERSION=3.11.4


to fix #7333

It's confusing to refer to that issue as it's already closed.

Can you explain why upgrading python is needed in order to support 3.11?

In particular, would it suffice to stick to 3.10 (not saying we should) and only pass -p 3.11 to python inspector by default ?

sschuberth · 2023-09-28T09:50:27Z

Dockerfile-legacy

@@ -33,7 +33,7 @@ ARG ORT_VERSION="DOCKER-SNAPSHOT"
 ARG NUGET_INSPECTOR_VERSION=0.9.12

 # Set this to the Python Inspector version to use.
-ARG PYTHON_INSPECTOR_VERSION="0.9.6"
+ARG PYTHON_INSPECTOR_VERSION="0.9.8"


Both updates are necessary to fix #7333 and the CI pipeline

Again, it's confusing to refer to that issue as it's already closed, and the previous commit already was said to fix it, too.

mawl · 2023-09-29T06:25:48Z

I think we should stop the work here as more happens in #7598 - I will close this PR for now.

mawl requested a review from a team as a code owner September 19, 2023 09:36

mawl changed the title ~~Issue #7476~~ fix: #7476 - Support python 3.11 Sep 19, 2023

mawl changed the title ~~fix: #7476 - Support python 3.11~~ feat(python): #7476 - Support python 3.11 Sep 19, 2023

sschuberth previously requested changes Sep 19, 2023

View reviewed changes

plugins/package-managers/python/src/main/kotlin/Pip.kt Show resolved Hide resolved

Dockerfile Show resolved Hide resolved

mawl force-pushed the Issue-7476 branch 3 times, most recently from 29476de to da01f67 Compare September 19, 2023 10:55

sschuberth requested a review from a team September 19, 2023 11:03

mawl force-pushed the Issue-7476 branch 2 times, most recently from 3383d8e to 4c18f88 Compare September 19, 2023 13:46

mawl changed the title ~~feat(python): #7476 - Support python 3.11~~ feat(python): #7476 - Support Python 3.11 Sep 19, 2023

mawl force-pushed the Issue-7476 branch 6 times, most recently from ced1553 to cc95613 Compare September 26, 2023 06:05

mawl force-pushed the Issue-7476 branch from cc95613 to aff72c9 Compare September 26, 2023 06:19

mawl force-pushed the Issue-7476 branch from aff72c9 to d29f1f1 Compare September 26, 2023 06:22

mnonnenmacher reviewed Sep 26, 2023

View reviewed changes

chore(deps): Update python-inspector and poetry

e6b8709

Update Dockerfile-legacy * python-inspector from 0.9.6 to 0.9.8 * poetry from 1.2.2 to 1.6.1 Both updates are necessary to fix oss-review-toolkit#7333 and the CI pipeline Signed-off-by: mawl <[email protected]>

mawl force-pushed the Issue-7476 branch from 41fdee2 to e6b8709 Compare September 26, 2023 13:08

Merge branch 'main' into Issue-7476

79991e5

Signed-off-by: mawl <[email protected]>

Update Python and Pyenv in .versions file

f2e8e91

Update Python from 3.10.13 to 3.11.4 Update Pyenv from v2.3.25 to v2.3.27 Signed-off-by: mawl <[email protected]>

heliocastro approved these changes Sep 28, 2023

View reviewed changes

sschuberth requested changes Sep 28, 2023

View reviewed changes

sschuberth mentioned this pull request Sep 28, 2023

fix(docker): Re-align the Poetry version #7595

Merged

fviernau mentioned this pull request Sep 28, 2023

feat(package-managers/python)!: Support Python 3.11 #7598

Merged

heliocastro self-requested a review September 28, 2023 12:01

mawl closed this Sep 29, 2023

mawl deleted the Issue-7476 branch September 29, 2023 06:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(python): #7476 - Support Python 3.11 #7533

feat(python): #7476 - Support Python 3.11 #7533

mawl commented Sep 19, 2023 •

edited

Loading

sschuberth left a comment

codecov bot commented Sep 19, 2023 •

edited

Loading

mawl commented Sep 26, 2023

sschuberth commented Sep 26, 2023

mawl commented Sep 26, 2023

mawl commented Sep 26, 2023

sschuberth commented Sep 26, 2023

mnonnenmacher Sep 26, 2023

mawl Sep 26, 2023

mnonnenmacher Sep 26, 2023

mnonnenmacher commented Sep 26, 2023

heliocastro commented Sep 26, 2023

heliocastro commented Sep 28, 2023

heliocastro left a comment

sschuberth left a comment

sschuberth Sep 28, 2023

fviernau Sep 28, 2023

sschuberth Sep 28, 2023 •

edited

Loading

mawl commented Sep 29, 2023

feat(python): #7476 - Support Python 3.11 #7533

feat(python): #7476 - Support Python 3.11 #7533

Conversation

mawl commented Sep 19, 2023 • edited Loading

sschuberth left a comment

Choose a reason for hiding this comment

codecov bot commented Sep 19, 2023 • edited Loading

Codecov Report

mawl commented Sep 26, 2023

sschuberth commented Sep 26, 2023

mawl commented Sep 26, 2023

mawl commented Sep 26, 2023

sschuberth commented Sep 26, 2023

mnonnenmacher Sep 26, 2023

Choose a reason for hiding this comment

mawl Sep 26, 2023

Choose a reason for hiding this comment

mnonnenmacher Sep 26, 2023

Choose a reason for hiding this comment

mnonnenmacher commented Sep 26, 2023

heliocastro commented Sep 26, 2023

heliocastro commented Sep 28, 2023

heliocastro left a comment

Choose a reason for hiding this comment

sschuberth left a comment

Choose a reason for hiding this comment

sschuberth Sep 28, 2023

Choose a reason for hiding this comment

fviernau Sep 28, 2023

Choose a reason for hiding this comment

sschuberth Sep 28, 2023 • edited Loading

Choose a reason for hiding this comment

mawl commented Sep 29, 2023

mawl commented Sep 19, 2023 •

edited

Loading

codecov bot commented Sep 19, 2023 •

edited

Loading

sschuberth Sep 28, 2023 •

edited

Loading