Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docker): Re-align the Poetry version #7595

Merged
merged 1 commit into from
Sep 28, 2023
Merged

Conversation

fviernau
Copy link
Member

Dockerfile and Dockerfile-legacy should use the same version. So, align on the latest one.

`Dockerfile` and `Dockerfile-legacy` should use the same version. So,
align on the latest one.

Signed-off-by: Frank Viernau <[email protected]>
@fviernau fviernau requested a review from a team as a code owner September 28, 2023 09:25
@fviernau fviernau enabled auto-merge (rebase) September 28, 2023 09:25
Copy link
Contributor

@heliocastro heliocastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good

@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (0de7894) 68.03% compared to head (5a8c5bc) 67.99%.
Report is 8 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #7595      +/-   ##
============================================
- Coverage     68.03%   67.99%   -0.04%     
- Complexity     2022     2032      +10     
============================================
  Files           344      344              
  Lines         16727    16760      +33     
  Branches       2371     2386      +15     
============================================
+ Hits          11380    11396      +16     
- Misses         4363     4382      +19     
+ Partials        984      982       -2     
Flag Coverage Δ
funTest-non-docker 36.44% <ø> (-0.03%) ⬇️
test 35.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@sschuberth sschuberth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this conflicts with #7533, but this change is better.

@fviernau fviernau merged commit 7e3de27 into main Sep 28, 2023
22 checks passed
@fviernau fviernau deleted the docker-fix-poetry-version branch September 28, 2023 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants