🌱 Add counting of shell parsing errors #1026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ristomcgehee
force-pushed
the
count-shell-parse-errors
branch
from
c301dd4
to
92ab4ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Metrics
What is the new behavior (if this is a feature change)?
As per BUG: Parsing errors #839 (comment), I am adding a metric to count the number of times that shell parsing fails. Based on how prevalent this is, we can decide how we want to handle these errors.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No
Other information:
I have not tested this code on a Scorecard Kubernetes cluster. Someone who has experience with the Scorecard cluster may want to test this PR. I'm open to learning how to test changes in
cronbefore pushing live code, but I'd need some instruction in that.