Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Song 559 change base schema #573

Merged
merged 42 commits into from
Jan 7, 2020
Merged

Song 559 change base schema #573

merged 42 commits into from
Jan 7, 2020

Conversation

rtisma
Copy link
Contributor

@rtisma rtisma commented Jan 6, 2020

Summary of changes

Related to #559

Renames:

  • study to studyId
  • file to files
  • sample to samples
  • donorGender to gender
  • donorSubmitterId to submitterDonorId
  • specimenSubmitterId to submitterSpecimenId
  • sampleSubmitterId to submitterSampleId

Added:

  • dataType to file object
  • matchedNormalSubmitterSampleId to sample object and is required when specimen.tumourNormalDesignation == Normal. It is prohibited if specimen.tumourNormalDesignation != Normal
  • tumourNormalDesgination to specimen object
  • specimenTissueSource

Updated enum:

  • gender enum from male, female, unspecified to Male, Female, Other
  • specimenType to match whatever is in argo-clinical

Removed:

  • specimenClass from baseSchema, however left column in DB as it cannot be automatically migrated (requires human intervention)

Misc:

  • changed /upload endpoint to /submit, and UploadController/Service to SubmitController/Service
  • cleaned up stale comments, and code
  • added test for matchedNormal validation
  • added V1__6 migration

Things that are not backwards compatible:

  • specimenType is nullable because previous specimenType data does not follow the enum in db.
  • same with tumourNormalDesignation and specimenTissueSource. These enforcements are entirely dependant on jsonSchema validation

@rtisma rtisma requested a review from andricDu January 6, 2020 18:43
@rtisma rtisma self-assigned this Jan 6, 2020
@rtisma rtisma added this to the Code Monkeys - Sprint 20 milestone Jan 6, 2020
@rtisma rtisma added the breaking-change Changes to the code might result in breaking-changes label Jan 6, 2020
Copy link
Contributor

@andricDu andricDu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rtisma rtisma merged commit 89ef5ff into develop Jan 7, 2020
@rtisma rtisma deleted the song-559-change-base-schema branch January 7, 2020 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Changes to the code might result in breaking-changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants