song-655-jwt-2 #661
Merged
song-655-jwt-2 #661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andricDu
approved these changes
Aug 7, 2020
| @@ -72,6 +73,7 @@ | |||
| SEQUENCING_READ_NOT_FOUND(NOT_FOUND), | |||
| VARIANT_CALL_NOT_FOUND(NOT_FOUND), | |||
| UNAUTHORIZED_TOKEN(UNAUTHORIZED), | |||
| FORBIDDEN_TOKEN(FORBIDDEN), | |||
| @@ -7,15 +7,15 @@ | |||
|
|
|||
| @Getter | |||
| public class ExpiringOauth2Authentication extends OAuth2Authentication { | |||
| private final int expiry; // expiry time of the authentication token in seconds | |||
| private final long expiry; // expiry time of the authentication token in seconds | |||
There was a problem hiding this comment.
Just a note, the AccessTokenConverterWithExpiry is still using int for the expiryInSeconds
| auth: | ||
| server: | ||
| url: "http://localhost:8084/check_token/" | ||
| clientId: "3kJhz9pNtC0pFHAxr2SPkUkGjXrkWWqGcnPC0vBP" |
There was a problem hiding this comment.
I'm assuming these are not real.
|
|
||
| private static long calcSecondsUntilExpiry(Long expirationTimestamp) { | ||
| val diff = expirationTimestamp - MILLISECONDS.toSeconds(currentTimeMillis()); | ||
| return diff > 0 ? diff : 0; |
There was a problem hiding this comment.
Generally this is fine, and you are fine in this situation, but you can get into trouble when boxing and widening happen in the wrong order. I would personally use 0L whenever I can because when using val you are boxing primitives. Again, you are fine in these situations, just something to think about.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.