Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds jwt auth #269

Merged
merged 8 commits into from
Aug 24, 2020
Merged

adds jwt auth #269

merged 8 commits into from
Aug 24, 2020

Conversation

jaserud
Copy link
Contributor

@jaserud jaserud commented Jul 27, 2020 •
edited
Loading

Proposed changes:

  • Add jwt spring profile
  • JWT converter and ego auth extraction
  • Added tests

some things are same/similar from : overture-stack/SONG#661

@jaserud jaserud requested a review from rtisma July 27, 2020 13:45
@jaserud jaserud self-assigned this Jul 27, 2020
@jaserud jaserud removed the request for review from rtisma August 12, 2020 13:53
@jaserud
Copy link
Contributor Author

jaserud commented Aug 12, 2020

Will ask to review after tests are added

@jaserud jaserud removed their assignment Aug 12, 2020
@jaserud jaserud requested a review from rtisma August 13, 2020 13:43
rtisma
rtisma suggested changes Aug 18, 2020
View reviewed changes
Copy link
Contributor

@rtisma rtisma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, however there are still something that need to be fixed with the testing.

score-server/src/main/java/bio/overture/score/server/config/SecurityConfig.java Outdated Show resolved Hide resolved
score-server/src/main/java/bio/overture/score/server/config/SecurityConfig.java Outdated Show resolved Hide resolved
score-server/src/main/java/bio/overture/score/server/config/TokenServicesConfig.java Outdated Show resolved Hide resolved
score-server/src/main/java/bio/overture/score/server/config/TokenServicesConfig.java Outdated Show resolved Hide resolved
score-server/src/main/java/bio/overture/score/server/security/JWTConverter.java Outdated Show resolved Hide resolved
score-server/src/test/java/bio/overture/score/server/security/JWTSecurityTest.java Outdated Show resolved Hide resolved
score-server/src/test/java/bio/overture/score/server/security/JWTSecurityTest.java Outdated Show resolved Hide resolved
score-server/src/test/java/bio/overture/score/server/security/JWTSecurityTest.java Outdated Show resolved Hide resolved
score-server/src/test/java/bio/overture/score/server/security/JWTSecurityTest.java Show resolved Hide resolved
score-server/src/test/java/bio/overture/score/server/security/JWTSecurityTest.java Outdated Show resolved Hide resolved
@jaserud jaserud requested a review from rtisma August 20, 2020 14:00
@jaserud jaserud requested a review from rtisma August 21, 2020 13:21
@jaserud jaserud merged commit 12863cd into develop Aug 24, 2020
@jaserud jaserud deleted the feat/267-jwt-auth branch August 24, 2020 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rtisma rtisma rtisma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaserud @rtisma