-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Some crashes in 4.2.0 (Play Store) #4323
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Referencing the different crashes listed in the issue:
|
Aitorbp
approved these changes
Feb 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🥇
Thanks for the tips @JuancaG05. Some basic checks performed over:
in oC10 and oCIS accounts I did not notice changes in the expected behaviour. Let's move this one to 4.2.1 |
JuancaG05
force-pushed
the
fix/crashes_google_play_4.2.0
branch
2 times, most recently
from
February 21, 2024 15:29
26a4e40
to
580b26e
Compare
…unt in BaseActivity is null (shouldn't happen in normal situations)
…unt in FolderPickerActivity is null (shouldn't happen in normal situations)
JuancaG05
force-pushed
the
fix/crashes_google_play_4.2.0
branch
from
February 21, 2024 15:36
ce64d10
to
3097905
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
App: #4318
QA