Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Some crashes in 4.2.0 (Play Store) #4323

Merged
merged 5 commits into from
Feb 21, 2024

Conversation

JuancaG05
Copy link
Collaborator

@JuancaG05 JuancaG05 commented Feb 20, 2024

Related Issues

App: #4318

  • Added changelog files for the fixed issues in folder changelog/unreleased. More info here

QA

@JuancaG05 JuancaG05 self-assigned this Feb 20, 2024
@JuancaG05 JuancaG05 linked an issue Feb 20, 2024 that may be closed by this pull request
@JuancaG05
Copy link
Collaborator Author

Referencing the different crashes listed in the issue:

  1. This one should be solved. It can be tested by creating the ReceiveExternalFilesActivity (when sharing with ownCloud from other app) and seeing if it shows the correct view (list of spaces in case it is oCIS, root folder of the correct account in case it is oC10...).
  2. This one is a more complex one because it deals with some not common race conditions. I added an additional safety layer to avoid this exception. It seems the main occurrences for this crash happen when navigating to the Shares/Shared by link and Av. offline tabs, so it can be tested by checking everything is correct when navigating to those tabs (no crash, correct folder and files shown...). Anyway, not common occurrences, so could be difficult to reproduce...
  3. This is happening in database migration for users that come from app versions with database older than version 27 (April 2019). We're in database version 44 right now. I don't think solving this is worth it, but if you think it is, just tell me and I'll take a deeper look 🤠.
  4. Shouldn't happen if the device is minimally performant, since it happens when replacing fragments on screen. I did nothing to handle this as it is not so frequent (just 3 occurrences since the release is out), but could be checked in future releases if it continues happening. In any case, this is happening when we go to the details screen and the file cannot be loaded for some reason, which shouldn't happen, and that's why they are just punctual cases.
  5. I proceeded more or less the same as in crash number 2, so that it has an additional layer of safety now. This one seems to occur when we create the FolderPickerActivity (the folder selector) when we want to choose a folder for the camera uploads, so tests could go that direction as well.

@JuancaG05 JuancaG05 marked this pull request as ready for review February 21, 2024 14:00
Copy link
Collaborator

@Aitorbp Aitorbp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥇

@jesmrec
Copy link
Collaborator

jesmrec commented Feb 21, 2024

Thanks for the tips @JuancaG05. Some basic checks performed over:

  • Sharing from 3rd party apps
  • Browsing across the bottom bar's tabs
  • Folder selector in auto-uploads

in oC10 and oCIS accounts

I did not notice changes in the expected behaviour. Let's move this one to 4.2.1

@JuancaG05 JuancaG05 changed the base branch from master to release/4.2.1 February 21, 2024 15:19
@JuancaG05 JuancaG05 force-pushed the fix/crashes_google_play_4.2.0 branch 2 times, most recently from 26a4e40 to 580b26e Compare February 21, 2024 15:29
@JuancaG05 JuancaG05 merged commit bc9b34a into release/4.2.1 Feb 21, 2024
2 of 3 checks passed
@JuancaG05 JuancaG05 deleted the fix/crashes_google_play_4.2.0 branch February 21, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Some crashes in 4.2.0 (Play Store)
3 participants