Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Some crashes in 4.2.0 (Play Store) #4323

Merged
merged 5 commits into from
Feb 21, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
# Table of Contents

* [Changelog for unreleased](#changelog-for-owncloud-android-client-unreleased-unreleased)
* [Changelog for 4.2.0](#changelog-for-owncloud-android-client-420-2024-02-05)
* [Changelog for 4.1.1](#changelog-for-owncloud-android-client-411-2023-10-18)
* [Changelog for 4.1.0](#changelog-for-owncloud-android-client-410-2023-08-23)
Expand All @@ -18,6 +19,26 @@
* [Changelog for 2.18.1](#changelog-for-owncloud-android-client-2181-2021-07-20)
* [Changelog for 2.18.0](#changelog-for-owncloud-android-client-2180-2021-05-24)
* [Changelog for 2.17 versions and below](#changelog-for-217-versions-and-below)
# Changelog for ownCloud Android Client [unreleased] (UNRELEASED)

The following sections list the changes in ownCloud Android Client unreleased relevant to
ownCloud admins and users.

[unreleased]: https://github.com/owncloud/android/compare/v4.2.0...master

## Summary

* Bugfix - Some crashes in 4.2.0: [#4318](https://github.com/owncloud/android/issues/4318)

## Details

* Bugfix - Some crashes in 4.2.0: [#4318](https://github.com/owncloud/android/issues/4318)

Several crashes reported by Play Console in version 4.2.0 have been fixed.

https://github.com/owncloud/android/issues/4318
https://github.com/owncloud/android/pull/4323

# Changelog for ownCloud Android Client [4.2.0] (2024-02-05)

The following sections list the changes in ownCloud Android Client 4.2.0 relevant to
Expand Down
6 changes: 6 additions & 0 deletions changelog/unreleased/4323
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
Bugfix: Some crashes in 4.2.0

Several crashes reported by Play Console in version 4.2.0 have been fixed.

https://github.com/owncloud/android/issues/4318
https://github.com/owncloud/android/pull/4323
Original file line number Diff line number Diff line change
Expand Up @@ -213,6 +213,9 @@ protected boolean isRedirectingToSetupAccount() {

public FileDataStorageManager getStorageManager() {
if (mStorageManager == null) {
if (getAccount() == null) {
swapToDefaultAccount();
}
return mStorageManager = new FileDataStorageManager(getAccount());
} else {
return mStorageManager;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -238,6 +238,9 @@ open class FolderPickerActivity : FileActivity(),

private fun initAndShowListOfFilesFragment(spaceId: String? = null) {
val safeInitialFolder = if (file == null) {
if (account == null) {
account = AccountUtils.getCurrentOwnCloudAccount(applicationContext)
}
val fileDataStorageManager = FileDataStorageManager(account)
fileDataStorageManager.getFileByPath(OCFile.ROOT_PATH, spaceId)
} else {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,6 @@ protected void onCreate(Bundle savedInstanceState) {

mReceiveExternalFilesViewModel = get(ReceiveExternalFilesViewModel.class);
subscribeToViewModels();
mReceiveExternalFilesViewModel.getPersonalSpaceForAccount(getAccount().name);

initPickerListener();

Expand Down