Use of baseURL in acceptance tests

[phil-davis]

The API acceptance tests are passed the base URL of the server-under-test in a format like:

http://localhost:8080/ocs/
http://localhost:8080/cloudfolder/ocs/

when they want to access some API endpoint that does not start with ocs/ then they take the ocs/ off and then add the required string for the URL.

The webUI acceptance tests are passed the base URL of the server-under-test in a format like:

http://localhost:8080/
http://localhost:8080/cloudfolder/

and they add the ocs/ or other endpoint URL as needed to access API endpoints.

Also it is not currently consistent if the passed-in base URL always has a / at the end or not.

This all makes a bit of a muddle for different methods that are in "API acceptance" classes and "webUI acceptance" classes.

To discuss/decide:

• common standard format for storing baseURL
• whether to require a \ at the end, or not, or be flexible parsing the passed-in value

@individual-it @SergioBertolinSG @davitol

[phil-davis]

My suggestions:

• pass in and store just the "really base" part like http://localhost:8080 or http://localhost:8080/cloudfolder
• cope with the passed-in baseURL parameter having a / at the end (easy to be flexible when parsing the passed-in value)
• store the baseURL only in 1 place in an API acceptance test context class (e.g. FeatureContext). The webUI acceptance test context classes can get it from there if they need it.

[ownclouders]

GitMate.io thinks possibly related issues are #22485 (test), #22492 (test), #30863 (Cleanup double-slash URLs in acceptance tests), #30493 (Rename integration API tests to acceptance), and #30833 (Refactor acceptance tests to use common user-group-server).

[SergioBertolinSG]

@phil-davis I fully agree with changing this. But be aware that it involves changes in many functions, as many of them to create the request url starts using baseUrl, for example:

$fullUrl = $this->baseUrl . "v2.php/cloud/users/$user/groups";

It will affect also acceptance tests of apps also (customgroups, guests, etc).

[phil-davis]

Yes, it will need careful examination of everything that uses, passes... baseURL !

[phil-davis]

PRs merged. webUI acceptance tests now use the "API test" view of baseUrl to know where to browse etc.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.