Remove /ocs/ from end of acceptance tests baseUrl

[phil-davis]

Description

1. Set baseUrl in the API acceptance tests to no longer have /ocs/ on the end of it.
2. Provide convenience methods to return the baseUrl with an without a trailing slash.
3. Everywhere that used to do stuff like substr($this->baseUrl, 0, -5) now use the method to get baseUrl
4. Update webUI test code so it consistently uses baseUrl from the API FeatureContext and does not keep trying to get it from getMinkParameter("base_url")

Related Issue

#30879
owncloud/QA#517

Motivation and Context

Bring API and UI acceptance tests even closer together. By using a common format for baseUrl it will be easier to make a common script for running any acceptance test.

How Has This Been Tested?

Locally and CI

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Test refactoring

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

[codecov]

Codecov Report

Merging #30943 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             master   #30943    +/-   ##
==========================================
  Coverage     62.28%   62.28%            
+ Complexity    18396    18233   -163     
==========================================
  Files          1141     1141            
  Lines         68154    68154            
  Branches       1232     1232            
==========================================
  Hits          42449    42449            
  Misses        25344    25344            
  Partials        361      361

Flag	Coverage Δ	Complexity Δ
#javascript	52.04% <ø> (ø)	0 <ø> (ø)	⬇️
#phpunit	63.45% <ø> (ø)	18233 <ø> (-163)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b629020...22ce7b2. Read the comment docs.

[phil-davis]

These rtrim() are here for the benefit of future users. If they pass in the baseURL parameter with a / on the end, then we will cope with that.

[phil-davis]

Backport stable10 #30953

[individual-it]

👍 if CI passes

[phil-davis]

App acceptance test changes to work with this:

• customgroups Remove /ocs/ from end of acceptance tests baseUrl customgroups#141
• files_texteditor - works without changes
• firewall https://github.com/owncloud/firewall/pull/477
• guests Remove /ocs/ from end of acceptance tests baseUrl guests#199
• notifications Remove /ocs/ from end of acceptance tests baseUrl notifications#160
• ransomware_protection https://github.com/owncloud/ransomware_protection/pull/100
• user_ldap Remove /ocs/ from end of acceptance tests baseUrl user_ldap#220
• user_management Remove /ocs/ from end of acceptance tests baseUrl owncloud-archive/user_management#15
• WND https://github.com/owncloud/windows_network_drive/pull/160

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.