Cleanup double-slash URLs in acceptance tests

[phil-davis]

Description

In places where the acceptance tests use baseURL and append stuff to it, add checks that put a / after baseURL only if baseURL does not already end in a /

That makes it flexible to have baseURL passed in with or without a trailing slash, and to not get double-slash sent in API requests.

Related Issue

owncloud/QA#517

Motivation and Context

When running acceptance tests, on the PHP server we see requests like:

[Thu Mar 22 10:00:06 2018] 127.0.0.1:45804 [200]: /ocs//v1.php/apps/testing/api/v1/increasefileid
[Thu Mar 22 10:00:06 2018] 127.0.0.1:45806 [200]: //ocs/v1.php/cloud/capabilities
[Thu Mar 22 10:00:06 2018] 127.0.0.1:45808 [200]: //ocs/v1.php/apps/testing/api/v1/apps
[Thu Mar 22 10:00:07 2018] 127.0.0.1:45810 [200]: //ocs/v1.php/apps/testing/api/v1/app/core/shareapi_enabled
[Thu Mar 22 10:00:07 2018] 127.0.0.1:45812 [200]: //ocs/v1.php/cloud/capabilities
[Thu Mar 22 10:00:07 2018] 127.0.0.1:45814 [200]: //ocs/v1.php/apps/testing/api/v1/app/core/shareapi_enabled

Nothing bad goes wrong, ownCloud copes with "random" double-slash in the URI. But it makes people ask questions when they notice this in acceptance test output. So it is good to clean it up.

How Has This Been Tested?

Local runs of some API acceptance tests now give requests like:

[Thu Mar 22 09:53:57 2018] 127.0.0.1:45418 [200]: /ocs/v1.php/apps/testing/api/v1/increasefileid
[Thu Mar 22 09:53:57 2018] 127.0.0.1:45420 [200]: /ocs/v1.php/cloud/capabilities
[Thu Mar 22 09:53:57 2018] 127.0.0.1:45422 [200]: /ocs/v1.php/apps/testing/api/v1/apps
[Thu Mar 22 09:53:57 2018] 127.0.0.1:45424 [200]: /ocs/v1.php/apps/testing/api/v1/app/core/shareapi_enabled
[Thu Mar 22 09:53:57 2018] 127.0.0.1:45426 [200]: /ocs/v1.php/cloud/capabilities
[Thu Mar 22 09:53:57 2018] 127.0.0.1:45428 [200]: /ocs/v1.php/apps/testing/api/v1/app/core/shareapi_enabled

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Acceptance test refactoring

Checklist:

• [x My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

[codecov]

Codecov Report

Merging #30863 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #30863   +/-   ##
=========================================
  Coverage     62.25%   62.25%           
  Complexity    18205    18205           
=========================================
  Files          1140     1140           
  Lines         68043    68043           
  Branches       1230     1230           
=========================================
  Hits          42362    42362           
  Misses        25318    25318           
  Partials        363      363

Flag	Coverage Δ	Complexity Δ
#javascript	51.99% <ø> (ø)	0 <ø> (ø)	⬇️
#phpunit	63.42% <ø> (ø)	18205 <ø> (ø)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ffd950...583fcc9. Read the comment docs.

[phil-davis]

Backport stable10 #30864

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.