move upload progress bar near upload button, more contextual #4498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| display:inline-block; | ||
| } | ||
| #uploadprogresswrapper #uploadprogressbar + stop { |
There was a problem hiding this comment.
Are there multiple #uploadprogressbars? If there aren't: remove the first id
|
Ref #991 by the way. Doesn’t fix it completely because this is only about the main upload bar and not about the individual ones. |
|
@Kondou-ger fixed |
|
👍 I'd however suggest having some pixels of margin between the stop button and the progressbar, as it looks very squashed together now. |
|
In IE8 the progress bar isn't there anyway (also for master) see #4417 |
|
@owncloud-bot retest this please |
|
Otherwise it's all fine 👍 |
Niduroki
pushed a commit
that referenced
this pull request
Aug 18, 2013
move upload progress bar near upload button, more contextual
|
Test passed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just move the upload bar from the far right of the bar to the left – directly right next to the upload button which triggered the upload action.
Please check @owncloud/designers