Combine upload action into the "New" menu #18630
Conversation
Refactored the new menu to be encapsulated in the NewFileMenu JS class
|
Let me rebase this onto master first so we get the latest styles. |
PVince81
force-pushed
the
files-combineuploadbutton
branch
from
c9194b9
to
59273a8
Compare
|
Rebased. (Jenkins will stumble and fall) |
|
Text file icon is missing. |
|
where are we with that? We need this for 8.2 |
|
Fixed some layout issues. @PVince81 when I click New file or Folder, the input field does not show right away, but this: |
|
Strange, works fine in Chromium but Firefox shows the three dots |
|
There's a text-overflow: ellipsis on every menu item. For some reason it kicks in in Firefox but not Chromium. I'll disable it for this specific menu. Last time I checked that all possible translations of "New file" would fit the current width, so it should be fine. |
|
@jancborchardt I removed the ellipsis, should work now. I'll take care of unit tests. |
- added unit tests for NewFileMenu - use generateUrl for FileList.createFile and FileList.createDirectory - added unit tests for FileList.createFile and FileList.createDirectory
|
A new inspection was created. |
|
Unit tests were added. @jancborchardt when you're done with the design, please set the label to "to review". |
|
Can we review and merge this? Quite important :-) |
|
Tested and works 👍 |
|
Nice! :) 👍 any details we can fix in follow-up PRs. |
Combine upload action into the "New" menu
|
nice! |
Combine upload action into the "New" menu.
Also refactored the new menu to be encapsulated in the more portable NewFileMenu JS class.
Moved directory and file creation logic to the FileList class instead of having it floating in file-upload.js.
This is a simplified version of #18589 where the menu stays where it is. We can move it to the sidebar later.
@jancborchardt @MorrisJobke please review.
If we agree on the design/placement I'll write the missing unit tests.