Register valid root for all installed apps in console #19022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to use commands from apps that aren't enabled (so don't get loaded).
|
A new inspection was created. |
|
I guess this is no longer needed because of https://github.com/owncloud/core/pull/19039/files @nickvergessen @Xenopathic please retest #19019 with latest master - THX |
|
👍 fixes |
|
@Xenopathic please rebase for CI coverage |
no needed |
|
👍 |
DeepDiver1975
added a commit
that referenced
this pull request
Sep 16, 2015
Register valid root for all installed apps in console
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Might be unnecessary, but I think there are some cases where we want to be able to run app commands after the app is disabled, to perform last-chance maintenance tasks. Negligible security impact, since this only gets triggered from the CLI.
cc @nickvergessen @DeepDiver1975 @MorrisJobke
Fixes #19019