Define allowed app roots earlier

[LukasReschke]

The autoloader needs to be run before including the app.php, otherwise it depends on what app gets executed first and apps that rely on the dependency of other apps in app.php may break.

[LukasReschke]

@cosenal @BernhardPosselt THX

[BernhardPosselt]

Issue probably when the getter is called more than one time right?
I would not expect this from a getter :)

[LukasReschke]

Moved this to loadApps which should only be called once. That said, even if it is called twice the worst thing which can happen is to have the root allowed twice :)

[BernhardPosselt]

Perfect :) 👍

[cosenal]

That solves my issue 👍

[RobinMcCorkell]

This just (probably) broke upgrading apps, since the addValidRoot has been moved out of loadApp(). See #18839 (comment)

[DeepDiver1975]

This just (probably) broke upgrading apps, since the addValidRoot has been moved out of loadApp(). See #18839 (comment)

can we please get a clear state on this? THX

[RobinMcCorkell]

Phew, it seems we have just avoided disaster. loadApps() is called at least once during upgrades, so all enabled apps are properly loaded. However, we still have the problem that if some code somewhere tries to use loadApp() by itself, that app won't have its paths registered, so it will fail to load. Perhaps we should still have the addValidRoot() in loadApp() as well as in loadApps()?

[BernhardPosselt]

@Xenopathic sounds like a plan. Would have to make sure to not add duplicates, but IIRC its a hashmap anyways, so it should not be a problem right?

[RobinMcCorkell]

@BernhardPosselt Not a hash map, just a regular array. Adding duplicate entries will decrease performance by a small bit, so perhaps just changing it to a hashmap would be the easiest way to prevent duplicates.