Copy file to owner's trash when recipient moves out of share #27042

PVince81 · 2017-01-27T11:37:07Z

Description

Whenever a share recipient moves files or folders out of the share,
make a backup copy in the owner's trash just in case.

The metadata stays on the recipient's copy that was moved out.

Related Issue

Fixes #24053 (without activity entry)

Motivation and Context

Solves the case where the recipient is not reachable any more so the owner still has a chance to restore the file.

How Has This Been Tested?

Login as "user0" (owner)
Create a folder "shared"
Share "shared" with "user1" (recipient)
Login as "user1"
Create a file "shared/test.txt" and overwrite several times to create versions
Create a folder "shared/sub"
Create a file "shared/sub/testsub.txt" and overwrite several times to create versions
Rename "shared" to "shared_renamed" (this covers the path matching logic)
Move "sub" and "test.txt" out of the "shared_renamed" folder.
Login as "owner"
Check that trashbin contains both "sub/testsub.txt" and "test.txt"
Restore both
Check that both "test.txt" and "sub/testsub.txt" are restored in the "shared" folder (from the owner's perspective)
Check that both entries still have their versions attached

Screenshots (if appropriate):

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
All new and existing tests passed.

TODOs:

find a way to bypass the locking issue or find another place / hook to do this operation...

mention-bot · 2017-01-27T11:37:09Z

@PVince81, thanks for your PR! By analyzing the history of the files in this pull request, we identified @DeepDiver1975, @stevenbuehner and @bartv2 to be potential reviewers.

PVince81 · 2017-01-27T11:39:32Z

Currently when moving out "test/deletedk.txt" into the root as recipient:

{"reqId":"gpWkNw+rulBC4FrPhDt5","remoteAddr":"127.0.0.1","app":"webdav","message":"Exception: {\"Message\":\"HTTP\\\/1.1 423 \\\"test\\\/deletedk.txt\\\" is locked\",\"Exception\":\"OCA\\\\DAV\\\\Connector\\\\Sabre\\\\Exception\\\\FileLocked\",\"Code\":0,\"Trace\":\"
#0 \\\/srv\\\/www\\\/htdocs\\\/owncloud\\\/lib\\\/composer\\\/sabre\\\/dav\\\/lib\\\/DAV\\\/CorePlugin.php(642): OCA\\\\DAV\\\\Connector\\\\Sabre\\\\ObjectTree->move('test\\\/deletedk.t...', 'deletedk.txt')\\n
#1 [internal function]: Sabre\\\\DAV\\\\CorePlugin->httpMove(Object(Sabre\\\\HTTP\\\\Request), Object(Sabre\\\\HTTP\\\\Response))\\n
#2 \\\/srv\\\/www\\\/htdocs\\\/owncloud\\\/lib\\\/composer\\\/sabre\\\/event\\\/lib\\\/EventEmitterTrait.php(105): call_user_func_array(Array, Array)\\n
#3 \\\/srv\\\/www\\\/htdocs\\\/owncloud\\\/lib\\\/composer\\\/sabre\\\/dav\\\/lib\\\/DAV\\\/Server.php(479): Sabre\\\\Event\\\\EventEmitter->emit('method:MOVE', Array)\\n
#4 \\\/srv\\\/www\\\/htdocs\\\/owncloud\\\/lib\\\/composer\\\/sabre\\\/dav\\\/lib\\\/DAV\\\/Server.php(254): Sabre\\\\DAV\\\\Server->invokeMethod(Object(Sabre\\\\HTTP\\\\Request), Object(Sabre\\\\HTTP\\\\Response))\\n
#5 \\\/srv\\\/www\\\/htdocs\\\/owncloud\\\/apps\\\/dav\\\/appinfo\\\/v1\\\/webdav.php(58): Sabre\\\\DAV\\\\Server->exec()\\n
#6 \\\/srv\\\/www\\\/htdocs\\\/owncloud\\\/remote.php(164): require_once('\\\/srv\\\/www\\\/htdocs...')\\n
#7 {main}\",\"File\":\"\\\/srv\\\/www\\\/htdocs\\\/owncloud\\\/apps\\\/dav\\\/lib\\\/Connector\\\/Sabre\\\/ObjectTree.php\",\"Line\":271,\"User\":\"user1\"}","level":4,"time":"2017-01-27T11:38:59+00:00","method":"MOVE","url":"\/owncloud\/remote.php\/webdav\/test\/deletedk.txt","user":"user1"}

PVince81 · 2017-01-30T10:32:21Z

It looks like I won't be able to bypass the locking issue from this point of the code. The problem is that the View class already sets an exclusive lock earlier and it wouldn't be suitable to change that: https://github.com/owncloud/core/blob/v9.1.3/lib/private/Files/View.php#L767

So the only solution is to do the copy in question from within the pre rename hook, in which only a shared lock is applied.

PVince81 · 2017-01-30T11:03:41Z

TODO: find out who has the versions in a "recipient deletes" scenario

codecov-io · 2017-01-30T17:35:47Z

Codecov Report

❗ No coverage uploaded for pull request head (sharing-trashfileforownerwhenmovedout@47bdc5d).

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1e31f0...47bdc5d. Read the comment docs.

PVince81 · 2017-02-01T10:55:17Z

REQUIRES: Add integration test for trashbin #27069

PVince81 · 2017-02-01T17:22:30Z

make sure fed sharing doesn't break in this scenario due to "getOwner"

PVince81 · 2017-02-01T17:40:41Z

fix versions case ($ownerPath is wrong)
add unit tests + verify if versions were stored as well
integration test with versions ? (bootstrap missing...)

PVince81 · 2017-02-02T08:47:09Z

test where the shared folder name is different, in case of potential bugs

PVince81 · 2017-02-02T09:46:54Z

TODO: documentation ticket for 10.0

PVince81 · 2017-02-02T09:49:14Z

It's looking good and also works already.

The integration test covers only detecting if the file is in trashbin.
Some existing tests from Add integration test for trashbin #27069 ensure that the favorite info is kept, which confirms file id preservation for the recipient. The backup gets a new fileid but no metadata except versions.
Versions are copied to owner's trash backup just like for delete. This is not covered by integration tests (we lack version code there...) but is covered by the unit tests

PVince81 · 2017-02-02T10:26:37Z

This is now ready for review @jvillafanez @VicDeo @DeepDiver1975 @IljaN

PVince81 · 2017-02-02T15:33:11Z

Tests pass for me locally 😢

PVince81 · 2017-02-02T16:00:30Z

Rebasing as a tentative of luck

PVince81 · 2017-02-15T17:58:21Z

Let's see... maybe I can just register an encryption wrapper in the tests... at least this will bring all tests closer to reality.

PVince81 · 2017-02-15T18:02:46Z

Here we go, the encryption wrapper fixes the test: e22d634

jvillafanez · 2017-02-16T09:03:52Z

I don't see any other change that should be done, so as long as it's working 👍

PVince81 · 2017-02-16T09:07:23Z

So... now StorageTests pass but TrashbinTest fail again 😢

PVince81 · 2017-02-16T09:46:09Z

Failure on pgsql now, so much fun:

19:35:56 1) OCA\Files_Trashbin\Tests\StorageTest::testOwnerBackupWhenMovingFileOutOfShare
19:35:56 Doctrine\DBAL\Exception\DriverException: An exception occurred while executing 'SELECT "path", "fileid" FROM "oc_filecache" WHERE "storage" = ? AND "path" LIKE ?' with params [false, "sub\/%"]:
19:35:56 
19:35:56 SQLSTATE[22P02]: Invalid text representation: 7 ERROR:  invalid input syntax for integer: ""
19:35:56 
19:35:56 /var/lib/jenkins/workspace/owncloud-core_core_PR-27042-D3EHZDNEIUXO3TN26UHXFNK7YRY4G5SCHC33PRCY6GB2OV74TYEA/lib/composer/doctrine/dbal/lib/Doctrine/DBAL/Driver/AbstractPostgreSQLDriver.php:91
19:35:56 /var/lib/jenkins/workspace/owncloud-core_core_PR-27042-D3EHZDNEIUXO3TN26UHXFNK7YRY4G5SCHC33PRCY6GB2OV74TYEA/lib/composer/doctrine/dbal/lib/Doctrine/DBAL/DBALException.php:128
19:35:56 /var/lib/jenkins/workspace/owncloud-core_core_PR-27042-D3EHZDNEIUXO3TN26UHXFNK7YRY4G5SCHC33PRCY6GB2OV74TYEA/lib/composer/doctrine/dbal/lib/Doctrine/DBAL/Connection.php:836
19:35:56 /var/lib/jenkins/workspace/owncloud-core_core_PR-27042-D3EHZDNEIUXO3TN26UHXFNK7YRY4G5SCHC33PRCY6GB2OV74TYEA/lib/private/DB/Connection.php:192
19:35:56 /var/lib/jenkins/workspace/owncloud-core_core_PR-27042-D3EHZDNEIUXO3TN26UHXFNK7YRY4G5SCHC33PRCY6GB2OV74TYEA/lib/private/Files/Cache/Cache.php:514
19:35:56 /var/lib/jenkins/workspace/owncloud-core_core_PR-27042-D3EHZDNEIUXO3TN26UHXFNK7YRY4G5SCHC33PRCY6GB2OV74TYEA/lib/private/Files/Cache/Updater.php:197
19:35:56 /var/lib/jenkins/workspace/owncloud-core_core_PR-27042-D3EHZDNEIUXO3TN26UHXFNK7YRY4G5SCHC33PRCY6GB2OV74TYEA/lib/private/Files/View.php:325
19:35:56 /var/lib/jenkins/workspace/owncloud-core_core_PR-27042-D3EHZDNEIUXO3TN26UHXFNK7YRY4G5SCHC33PRCY6GB2OV74TYEA/lib/private/Files/View.php:802
19:35:56 /var/lib/jenkins/workspace/owncloud-core_core_PR-27042-D3EHZDNEIUXO3TN26UHXFNK7YRY4G5SCHC33PRCY6GB2OV74TYEA/lib/private/Files/Node/Node.php:414
19:35:56 /var/lib/jenkins/workspace/owncloud-core_core_PR-27042-D3EHZDNEIUXO3TN26UHXFNK7YRY4G5SCHC33PRCY6GB2OV74TYEA/apps/files_trashbin/tests/StorageTest.php:496
19:35:56 
19:35:56 Caused by
19:35:56 Doctrine\DBAL\Driver\PDOException: SQLSTATE[22P02]: Invalid text representation: 7 ERROR:  invalid input syntax for integer: ""
19:35:56 
19:35:56 /var/lib/jenkins/workspace/owncloud-core_core_PR-27042-D3EHZDNEIUXO3TN26UHXFNK7YRY4G5SCHC33PRCY6GB2OV74TYEA/lib/composer/doctrine/dbal/lib/Doctrine/DBAL/Driver/PDOStatement.php:93
19:35:56 /var/lib/jenkins/workspace/owncloud-core_core_PR-27042-D3EHZDNEIUXO3TN26UHXFNK7YRY4G5SCHC33PRCY6GB2OV74TYEA/lib/composer/doctrine/dbal/lib/Doctrine/DBAL/Connection.php:830
19:35:56 /var/lib/jenkins/workspace/owncloud-core_core_PR-27042-D3EHZDNEIUXO3TN26UHXFNK7YRY4G5SCHC33PRCY6GB2OV74TYEA/lib/private/DB/Connection.php:192
19:35:56 /var/lib/jenkins/workspace/owncloud-core_core_PR-27042-D3EHZDNEIUXO3TN26UHXFNK7YRY4G5SCHC33PRCY6GB2OV74TYEA/lib/private/Files/Cache/Cache.php:514
19:35:56 /var/lib/jenkins/workspace/owncloud-core_core_PR-27042-D3EHZDNEIUXO3TN26UHXFNK7YRY4G5SCHC33PRCY6GB2OV74TYEA/lib/private/Files/Cache/Updater.php:197
19:35:56 /var/lib/jenkins/workspace/owncloud-core_core_PR-27042-D3EHZDNEIUXO3TN26UHXFNK7YRY4G5SCHC33PRCY6GB2OV74TYEA/lib/private/Files/View.php:325
19:35:56 /var/lib/jenkins/workspace/owncloud-core_core_PR-27042-D3EHZDNEIUXO3TN26UHXFNK7YRY4G5SCHC33PRCY6GB2OV74TYEA/lib/private/Files/View.php:802
19:35:56 /var/lib/jenkins/workspace/owncloud-core_core_PR-27042-D3EHZDNEIUXO3TN26UHXFNK7YRY4G5SCHC33PRCY6GB2OV74TYEA/lib/private/Files/Node/Node.php:414
19:35:56 /var/lib/jenkins/workspace/owncloud-core_core_PR-27042-D3EHZDNEIUXO3TN26UHXFNK7YRY4G5SCHC33PRCY6GB2OV74TYEA/apps/files_trashbin/tests/StorageTest.php:496
19:35:56 
19:35:56 Caused by
19:35:56 PDOException: SQLSTATE[22P02]: Invalid text representation: 7 ERROR:  invalid input syntax for integer: ""
19:35:56 
19:35:56 /var/lib/jenkins/workspace/owncloud-core_core_PR-27042-D3EHZDNEIUXO3TN26UHXFNK7YRY4G5SCHC33PRCY6GB2OV74TYEA/lib/composer/doctrine/dbal/lib/Doctrine/DBAL/Driver/PDOStatement.php:91
19:35:56 /var/lib/jenkins/workspace/owncloud-core_core_PR-27042-D3EHZDNEIUXO3TN26UHXFNK7YRY4G5SCHC33PRCY6GB2OV74TYEA/lib/composer/doctrine/dbal/lib/Doctrine/DBAL/Connection.php:830
19:35:56 /var/lib/jenkins/workspace/owncloud-core_core_PR-27042-D3EHZDNEIUXO3TN26UHXFNK7YRY4G5SCHC33PRCY6GB2OV74TYEA/lib/private/DB/Connection.php:192
19:35:56 /var/lib/jenkins/workspace/owncloud-core_core_PR-27042-D3EHZDNEIUXO3TN26UHXFNK7YRY4G5SCHC33PRCY6GB2OV74TYEA/lib/private/Files/Cache/Cache.php:514
19:35:56 /var/lib/jenkins/workspace/owncloud-core_core_PR-27042-D3EHZDNEIUXO3TN26UHXFNK7YRY4G5SCHC33PRCY6GB2OV74TYEA/lib/private/Files/Cache/Updater.php:197
19:35:56 /var/lib/jenkins/workspace/owncloud-core_core_PR-27042-D3EHZDNEIUXO3TN26UHXFNK7YRY4G5SCHC33PRCY6GB2OV74TYEA/lib/private/Files/View.php:325
19:35:56 /var/lib/jenkins/workspace/owncloud-core_core_PR-27042-D3EHZDNEIUXO3TN26UHXFNK7YRY4G5SCHC33PRCY6GB2OV74TYEA/lib/private/Files/View.php:802
19:35:56 /var/lib/jenkins/workspace/owncloud-core_core_PR-27042-D3EHZDNEIUXO3TN26UHXFNK7YRY4G5SCHC33PRCY6GB2OV74TYEA/lib/private/Files/Node/Node.php:414
19:35:56 /var/lib/jenkins/workspace/owncloud-core_core_PR-27042-D3EHZDNEIUXO3TN26UHXFNK7YRY4G5SCHC33PRCY6GB2OV74TYEA/apps/files_trashbin/tests/StorageTest.php:496
19:35:56

PVince81 · 2017-02-16T09:55:46Z

Looks like the source storage id is (bool)0 before the rename in the test.
Somehow SQLite and MySQL don't mind about this...

Need to make sure that the source storage exists in DB before doing this.

PVince81 · 2017-02-16T10:11:00Z

Arghhh, seems there is yet another bug in the FS code.

The SharedCache doesn't seem to forward all calls to the underlying cache, so it cannot get its numeric id.

PVince81 · 2017-02-16T10:25:27Z

This seems to fix it, but not sure how dangerous...

diff --git a/apps/files_sharing/lib/Cache.php b/apps/files_sharing/lib/Cache.php
index f09267cecd..b56f25d8fd 100644
--- a/apps/files_sharing/lib/Cache.php
+++ b/apps/files_sharing/lib/Cache.php
@@ -74,11 +74,7 @@ class Cache extends CacheJail {
        }
 
        public function getNumericStorageId() {
-               if (isset($this->numericId)) {
-                       return $this->numericId;
-               } else {
-                       return false;
-               }
+               return $this->sourceCache->getNumericStorageId();
        }
 
        protected function formatCacheEntry($entry) {

I wonder why this wasn't found before... Probably hidden by another bug that cancels it out ?

PVince81 · 2017-02-16T10:40:12Z

Looks like this code was completely wrong. There isn't even a numericId attribute neither in this class nor in the parent classes.

But so far no unit test failed because of this...

PVince81 · 2017-02-16T10:51:07Z

I made a separate PR for this fix with an extra unit test: #27172

PVince81 · 2017-02-16T11:11:54Z

I have now cherry-picked the fix from #27172 to this PR here.

Let's see if the tests pass first and then make a decision whether to keep the extra fix or not.

PVince81 · 2017-02-16T15:07:23Z

The extra fix has evolved a bit.

Waiting for #27172 to be merged then rebase.

Whenever a share recipient moves files or folders out of the share, make a backup copy in the owner's trash just in case. The metadata stays on the recipient's copy that was moved out.

Because the encryption wrapper does some twisted stuff with methods like moveFromStorage, we need to apply it here to make sure the behavior is close to reality.

PVince81 · 2017-02-21T10:24:01Z

Rebased to include the final fix from #27172

PVince81 · 2017-02-21T20:28:29Z

GREEN ! FINALLY GREEN ! After all these struggles.

I hope you'll enjoy this enhancement, guys...

PVince81 · 2017-02-21T20:31:16Z

Added to new features of 10.0: https://github.com/owncloud/core/wiki/ownCloud-10.0-Features

PVince81 · 2017-04-20T10:42:21Z

Regression: #27698

lock · 2019-08-03T13:02:17Z

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

PVince81 added 2 - Developing app:files_trashbin green-ticket labels Jan 27, 2017

PVince81 added this to the 10.0 milestone Jan 27, 2017

PVince81 self-assigned this Jan 27, 2017

PVince81 mentioned this pull request Jan 27, 2017

Alice can't restore files that Bob moved out of shared folder #24053

Closed

PVince81 force-pushed the sharing-trashfileforownerwhenmovedout branch from 327483c to 47bdc5d Compare January 31, 2017 18:18

PVince81 mentioned this pull request Feb 1, 2017

Add integration test for trashbin #27069

Merged

9 tasks

PVince81 force-pushed the sharing-trashfileforownerwhenmovedout branch from 47bdc5d to 270c30d Compare February 1, 2017 11:08

PVince81 changed the title ~~[WIP] Copy file to owner's trash when recipient moves out of share~~ Copy file to owner's trash when recipient moves out of share Feb 2, 2017

PVince81 added 3 - To Review and removed 2 - Developing labels Feb 2, 2017

PVince81 force-pushed the sharing-trashfileforownerwhenmovedout branch 2 times, most recently from 0eea85f to 5c1238e Compare February 2, 2017 10:25

PVince81 force-pushed the sharing-trashfileforownerwhenmovedout branch from 5c1238e to f3f1e3d Compare February 2, 2017 16:00

PVince81 mentioned this pull request Feb 3, 2017

[jenkins] Copy file to owner's trash when recipient moves out of share #27079

Closed

PVince81 mentioned this pull request Feb 14, 2017

Server side checksum verification #26655 #27097

Merged

9 tasks

PVince81 added 2 - Developing and removed 3 - To Review labels Feb 15, 2017

PVince81 mentioned this pull request Feb 16, 2017

Fix SharedCache to forward numeric id of wrapped cache #27172

Merged

10 tasks

PVince81 force-pushed the sharing-trashfileforownerwhenmovedout branch from e22d634 to 47acac7 Compare February 16, 2017 11:11

PVince81 added 4 - To release and removed 2 - Developing labels Feb 21, 2017

Vincent Petry added 2 commits February 21, 2017 11:23

Copy file to owner's trash when recipient moves out of share

5d70aa8

Whenever a share recipient moves files or folders out of the share, make a backup copy in the owner's trash just in case. The metadata stays on the recipient's copy that was moved out.

Register encryption storage wrapper in trashbin storage test

641d3dc

Because the encryption wrapper does some twisted stuff with methods like moveFromStorage, we need to apply it here to make sure the behavior is close to reality.

PVince81 force-pushed the sharing-trashfileforownerwhenmovedout branch from 47acac7 to 641d3dc Compare February 21, 2017 10:23

PVince81 merged commit 28c345d into master Feb 21, 2017

PVince81 deleted the sharing-trashfileforownerwhenmovedout branch February 21, 2017 20:28

lock bot locked as resolved and limited conversation to collaborators Aug 3, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Copy file to owner's trash when recipient moves out of share #27042

Copy file to owner's trash when recipient moves out of share #27042

PVince81 commented Jan 27, 2017 •

edited

Loading

mention-bot commented Jan 27, 2017

PVince81 commented Jan 27, 2017 •

edited

Loading

PVince81 commented Jan 30, 2017

PVince81 commented Jan 30, 2017 •

edited

Loading

codecov-io commented Jan 30, 2017 •

edited

Loading

PVince81 commented Feb 1, 2017 •

edited

Loading

PVince81 commented Feb 1, 2017

PVince81 commented Feb 1, 2017 •

edited

Loading

PVince81 commented Feb 2, 2017 •

edited

Loading

PVince81 commented Feb 2, 2017

PVince81 commented Feb 2, 2017

PVince81 commented Feb 2, 2017

PVince81 commented Feb 2, 2017

PVince81 commented Feb 2, 2017

PVince81 commented Feb 15, 2017

PVince81 commented Feb 15, 2017

jvillafanez commented Feb 16, 2017

PVince81 commented Feb 16, 2017

PVince81 commented Feb 16, 2017

PVince81 commented Feb 16, 2017

PVince81 commented Feb 16, 2017

PVince81 commented Feb 16, 2017

PVince81 commented Feb 16, 2017

PVince81 commented Feb 16, 2017

PVince81 commented Feb 16, 2017

PVince81 commented Feb 16, 2017

PVince81 commented Feb 21, 2017

PVince81 commented Feb 21, 2017

PVince81 commented Feb 21, 2017

PVince81 commented Apr 20, 2017

lock bot commented Aug 3, 2019

Copy file to owner's trash when recipient moves out of share #27042

Copy file to owner's trash when recipient moves out of share #27042

Conversation

PVince81 commented Jan 27, 2017 • edited Loading

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

TODOs:

mention-bot commented Jan 27, 2017

PVince81 commented Jan 27, 2017 • edited Loading

PVince81 commented Jan 30, 2017

PVince81 commented Jan 30, 2017 • edited Loading

codecov-io commented Jan 30, 2017 • edited Loading

Codecov Report

PVince81 commented Feb 1, 2017 • edited Loading

PVince81 commented Feb 1, 2017

PVince81 commented Feb 1, 2017 • edited Loading

PVince81 commented Feb 2, 2017 • edited Loading

PVince81 commented Feb 2, 2017

PVince81 commented Feb 2, 2017

PVince81 commented Feb 2, 2017

PVince81 commented Feb 2, 2017

PVince81 commented Feb 2, 2017

PVince81 commented Feb 15, 2017

PVince81 commented Feb 15, 2017

jvillafanez commented Feb 16, 2017

PVince81 commented Feb 16, 2017

PVince81 commented Feb 16, 2017

PVince81 commented Feb 16, 2017

PVince81 commented Feb 16, 2017

PVince81 commented Feb 16, 2017

PVince81 commented Feb 16, 2017

PVince81 commented Feb 16, 2017

PVince81 commented Feb 16, 2017

PVince81 commented Feb 16, 2017

PVince81 commented Feb 21, 2017

PVince81 commented Feb 21, 2017

PVince81 commented Feb 21, 2017

PVince81 commented Apr 20, 2017

lock bot commented Aug 3, 2019

PVince81 commented Jan 27, 2017 •

edited

Loading

PVince81 commented Jan 27, 2017 •

edited

Loading

PVince81 commented Jan 30, 2017 •

edited

Loading

codecov-io commented Jan 30, 2017 •

edited

Loading

PVince81 commented Feb 1, 2017 •

edited

Loading

PVince81 commented Feb 1, 2017 •

edited

Loading

PVince81 commented Feb 2, 2017 •

edited

Loading