Add integration test for trashbin #27069
Conversation
|
@PVince81, thanks for your PR! By analyzing the history of the files in this pull request, we identified @SergioBertolinSG, @DeepDiver1975 and @davitol to be potential reviewers. |
| And user "user1" exists | ||
| And user "user0" created a folder "/shared" | ||
| And User "user0" moved file "/textfile0.txt" to "/shared/shared_file.txt" | ||
| And file "/shared" of user "user0" is shared with user "user1" |
There was a problem hiding this comment.
you can use folder instead of file
Given /^(file|folder|entry)
There was a problem hiding this comment.
who cares 😉
I thought we could even ask an assertion that checks if the given type matches whatever is given. So if I say "file" but it's a folder, the test would fail. Not sure if this has a big benefit...
| And user "user1" exists | ||
| And user "user0" created a folder "/shared" | ||
| And User "user0" moved file "/textfile0.txt" to "/shared/shared_file.txt" | ||
| And file "/shared" of user "user0" is shared with user "user1" |
There was a problem hiding this comment.
you can use folder instead of file
Given /^(file|folder|entry)
| And user "user0" created a folder "/shared" | ||
| And user "user0" created a folder "/shared/sub" | ||
| And User "user0" moved file "/textfile0.txt" to "/shared/sub/shared_file.txt" | ||
| And file "/shared" of user "user0" is shared with user "user1" |
There was a problem hiding this comment.
you can use folder instead of file
Given /^(file|folder|entry)
Add test for basic deletion. Add test when deleting from shared folder as recipient. Add test to check that metadata stays when moving out of shared folder as recipient.
PVince81
force-pushed
the
inttest-trashbin-share
branch
from
4aa4270
to
383aa12
Compare
|
@SergioBertolinSG fixed |
|
Tests passed locally. Run using no variables and with encryption + alt home. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Description
Add test for basic deletion.
Add test when deleting from shared folder as recipient.
Add test to check that metadata stays when moving out of shared folder
as recipient.
Related Issue
This is the base work required to be able to add further tests for #27042
Motivation and Context
We do want tests for trashbin, do we ?
How Has This Been Tested?
Ran the individual scenarios and they passed.
Screenshots (if appropriate):
Types of changes
Checklist:
Note that this is using the private trashbin URLs as we don't have anything else.
If you're unhappy about this, then please consider pushing forward the discussion and review my API proposal here: #15646
@owncloud/qa @DeepDiver1975 please review