Fix files scan repair in bulk warning

[PVince81]

Description

Fix warning when running occ files:scan --repair --all without single user mode.
The message now only appears when --repair is actually passed.
Additionally, the message was improved to make more sense when read in this context.
The command now exits with an error code as it doesn't make sense to scan since the precondition was not met.

Related Issue

Found during smoke testing for 9.0.11RC1: #29627

Motivation and Context

How Has This Been Tested?

Manual testing of command with and without single user mode.
Without repair switch, no message must appear.

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

Backports:

• stable10
• stable9.1
• stable9

[PVince81]

stable9: #29630
stable9.1: #29632
stable10: #29631

[mmattel]

fyi: this has also been recently documented in owncloud-archive/documentation#3545 and doc backported to stable 10

[davitol]

Tested and works

[codecov]

Codecov Report

Merging #29629 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master   #29629      +/-   ##
============================================
- Coverage     61.82%   61.82%   -0.01%     
  Complexity    17501    17501              
============================================
  Files          1045     1045              
  Lines         57712    57713       +1     
============================================
  Hits          35683    35683              
- Misses        22029    22030       +1

Impacted Files	Coverage Δ	Complexity Δ
apps/files/lib/Command/Scan.php	0% <0%> (ø)	47 <0> (ø)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6de601...6b42f5a. Read the comment docs.

[PVince81]

I've added some tests to make codecov happy. The occ files:scan command didn't have any tests at all...

Please check ba21954

cc @DeepDiver1975 ^

[PVince81]

pfff, tests pass locally but not on Jenkins.

I'll move those to a separate PR

[PVince81]

moved tests here: #29635

[PVince81]

waiting for drone now...

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.