Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix files:scan repair + basic tests for files:scan command #29635

Merged
merged 3 commits into from
Feb 26, 2018
Merged

Fix files:scan repair + basic tests for files:scan command #29635

merged 3 commits into from
Feb 26, 2018

Conversation

PVince81
Copy link
Contributor

@PVince81 PVince81 commented Nov 20, 2017 •
edited
Loading

Will fail on CI, pass locally, needs work...

@PVince81 PVince81 added this to the planned milestone Nov 20, 2017
@PVince81 PVince81 self-assigned this Nov 20, 2017
@PVince81 PVince81 mentioned this pull request Nov 20, 2017
Merged
12 tasks
@PVince81 PVince81 modified the milestones: planned, development Nov 22, 2017
@PVince81
Copy link
Contributor Author

Ohhh that explains the failure: Testing with oci ...

@PVince81
Copy link
Contributor Author

running this one test class locally with oci passes... now to run the full set...

@PVince81
Copy link
Contributor Author

boo... local test run with Oracle and all tests does not fail...

@PVince81
Copy link
Contributor Author

also ran tests locally with filtering by group "DB" with oci, still doesn't fail...

@PVince81
Copy link
Contributor Author

@owncloud-bot rebase

@PVince81
Copy link
Contributor Author

rebased and hoping for some magic resolution...

@PVince81 PVince81 modified the milestones: development, planned Jan 12, 2018
@PVince81 PVince81 mentioned this pull request Jan 16, 2018
Merged
9 tasks
@PVince81
Copy link
Contributor Author

@owncloud-bot rebase please

@PVince81
Copy link
Contributor Author

@ownclouders rebase please

@ownclouders
Copy link
Contributor

Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently ⚠️

@ownclouders
Copy link
Contributor

Automated rebase with GitMate.io was successful! 🎉

@codecov
Copy link

codecov bot commented Jan 16, 2018 •
edited
Loading

Codecov Report

Merging #29635 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #29635      +/-   ##
============================================
+ Coverage     61.82%   61.88%   +0.05%     
  Complexity    19051    19051              
============================================
  Files          1089     1089              
  Lines         61442    61444       +2     
============================================
+ Hits          37988    38025      +37     
+ Misses        23454    23419      -35
Impacted Files Coverage Δ Complexity Δ
apps/files/lib/Command/Scan.php 76.25% <100%> (+10.28%) 72 <0> (ø) ⬇️
lib/private/Migration/ConsoleOutput.php 55% <0%> (+55%) 9% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48ef206...57b56ef. Read the comment docs.

@PVince81
Copy link
Contributor Author

Oh wait, it's the primary object store tests failing! I'll exclude those as scanning doesn't make sense there.

@PVince81
Copy link
Contributor Author

some weird errors not even related to this PR... it's like it was testing another PR...

anyway, rebased

@PVince81
Copy link
Contributor Author

Not even related to my PR ?!

1) OCA\Files\Tests\Command\ScanTest::testScanRepairAllInMaintenanceMode with data set #0 (array(array('singleuser', false, true), array('maintenance', false, false)))
ArgumentCountError: Too few arguments to function OC\Repair\RepairMismatchFileCachePath::__construct(), 2 passed in /drone/src/apps/files/lib/Command/Scan.php on line 157 and exactly 3 expected

@PVince81
Copy link
Contributor Author

oh wait, I read it wrong... oh...

@PVince81 PVince81 added regression p1-urgent Critical issue, need to consider hotfix with just that issue labels Feb 23, 2018
@PVince81 PVince81 changed the title Add basic tests for files:scan command Fix files:scan repair + basic tests for files:scan command Feb 23, 2018
tomneedham
tomneedham approved these changes Feb 26, 2018
View reviewed changes
Copy link
Member

@tomneedham tomneedham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Tests run locally and repair/scan command runs fine.

@PVince81 PVince81 merged commit 8783b37 into master Feb 26, 2018
@PVince81 PVince81 deleted the scan-command-unit-tests branch February 26, 2018 11:26
@PVince81
Copy link
Contributor Author

requires backport of #30020 to not have conflicts on ScanTest

@PVince81 PVince81 mentioned this pull request Feb 26, 2018
Merged
@PVince81
Copy link
Contributor Author

stable10: #30618

@PVince81 PVince81 mentioned this pull request Mar 28, 2018
Merged
9 tasks
@PVince81
Copy link
Contributor Author

Repair command was broken through #30451 (unreleased), so this PR could be counted as an addition to this one to fix it.

@ownclouders ownclouders mentioned this pull request Jun 13, 2018
Closed
@ownclouders ownclouders mentioned this pull request Jul 18, 2018
Closed
@ownclouders ownclouders mentioned this pull request Nov 22, 2018
Closed
7 tasks
@lock
Copy link

lock bot commented Jul 31, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tomneedham tomneedham tomneedham approved these changes

@DeepDiver1975 DeepDiver1975 Awaiting requested review from DeepDiver1975

Assignees

@PVince81 PVince81

Labels
3 - To Review p1-urgent Critical issue, need to consider hotfix with just that issue regression Type:Bug
Projects
None yet
Milestone
10.0.8
Development

Successfully merging this pull request may close these issues.
6 participants
@PVince81 @ownclouders @sharidas @patrickjahns @tomneedham @phil-davis