Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API test for removeSubAdmin #31390

Merged
merged 1 commit into from
May 8, 2018

Conversation

paurakhsharma
Copy link
Member

@paurakhsharma paurakhsharma commented May 8, 2018

Description

API test for removeSubAdmin
This PR has one skipped scenario which will pass only after resolving issue #31276

Related Issue

#31533

How Has This Been Tested?

Locally

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Acceptance test

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also add a scenario where an ordinary user in the group tries to remove the subadmin of their group, and make sure it does not succeed.

And the HTTP status code should be "200"

Scenario: subadmin tries to remove other subadmin in the group
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indent problem
also needs fixing in line 10 (old problem)

@codecov
Copy link

codecov bot commented May 8, 2018

Codecov Report

Merging #31390 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #31390   +/-   ##
=========================================
  Coverage     62.63%   62.63%           
  Complexity    18255    18255           
=========================================
  Files          1145     1145           
  Lines         68472    68472           
  Branches       1234     1234           
=========================================
  Hits          42890    42890           
  Misses        25221    25221           
  Partials        361      361
Flag Coverage Δ Complexity Δ
#javascript 52.05% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 63.84% <ø> (ø) 18255 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1c72cd...f52cdeb. Read the comment docs.

@paurakhsharma
Copy link
Member Author

Backport on #31396

@phil-davis phil-davis merged commit 83113f2 into owncloud:master May 8, 2018
@PVince81 PVince81 modified the milestones: development, QA Jun 13, 2018
@lock
Copy link

lock bot commented Jul 30, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants