Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand provisioning API acceptance tests #31533

Closed
2 tasks done
phil-davis opened this issue May 25, 2018 · 9 comments
Closed
2 tasks done

Expand provisioning API acceptance tests #31533

phil-davis opened this issue May 25, 2018 · 9 comments

Comments

@phil-davis
Copy link
Contributor

phil-davis commented May 25, 2018

Parent issue #31403

  • split Provisioning API acceptance tests into a sensible set of features
  • review the test scenarios in each feature and expand them to cover a "basic" set of test cases

(e.g. for each feature consider what an admin, subadmin, ordinary user, can and cannot do to create/delete/edit other users and groups)

@ownclouders
Copy link
Contributor

GitMate.io thinks possibly related issues are #31531 (Expand sharing API acceptance tests), #31403 (Expand API acceptance tests), #22485 (test), #22492 (test), and #30493 (Rename integration API tests to acceptance).

@ownclouders
Copy link
Contributor

Hey, this issue has been closed because the label status/STALE is set and there were no updates for 7 days. Feel free to reopen this issue if you deem it appropriate.

(This is an automated comment from GitMate.io.)

@phil-davis
Copy link
Contributor Author

I need to go over this and check if there is more to do.

@phil-davis
Copy link
Contributor Author

Just found this again - to do: see if there is anything useful still to do!

@kiranparajuli589
Copy link
Contributor

Just found this again - to do: see if there is anything useful still to do!

@phil-davis we can separate ldap methods from Provisioning and put into some helper

@phil-davis
Copy link
Contributor Author

Just found this again - to do: see if there is anything useful still to do!

@phil-davis we can separate ldap methods from Provisioning and put into some helper

We can do that, which will help Provisioning.php get smaller.

But actually for this issue I wanted to review all the features and scenarios in the apiProvisioning* suites and see if there are things that we have missed completely, or combinations/edge cases that we have not covered well.

Probably needs a whiteboard session to "map" what we have and what we need.

@kiranparajuli589
Copy link
Contributor

kiranparajuli589 commented Feb 6, 2020

@phil-davis, seems like very boring task to move forward! 😄 someone's gonna get very lucky!!

@phil-davis
Copy link
Contributor Author

@kiranparajuli589 it is assigned to me, so some day I will get started on it :)

@phil-davis
Copy link
Contributor Author

Test coverage has been extended by the PRs above - closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants