Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tests-Only] Expand API tests for getUser, removeSubAdmin and resetUserPassword #38327

Merged
merged 1 commit into from
Jan 26, 2021
Merged

[Tests-Only] Expand API tests for getUser, removeSubAdmin and resetUserPassword #38327

merged 1 commit into from
Jan 26, 2021

Conversation

saw-jan
Copy link
Member

@saw-jan saw-jan commented Jan 22, 2021 •
edited
Loading

Description

expands apiProvisioning tests for ocs v1 and v2 in:

  • getUser
  • removeSubAdmin
  • resetUserPassword

Related Issue

How Has This Been Tested?

  • test environment: drone 🤖

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

dpakach
dpakach reviewed Jan 22, 2021
View reviewed changes
tests/acceptance/features/apiProvisioning-v1/getUser.feature Outdated
| subadmin |
| another-subadmin |
And group "brand-new-group" has been created
And user "another-subadmin" has been made a subadmin of group "brand-new-group"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

user 'another-subadmin' is not added to the group 'brand-new -group' so I suspect this step will fail, please review this

Copy link
Member Author

@saw-jan saw-jan Jan 22, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This step passed in local run
We can make user subadmin of any group without adding him/her in that group.
(may be this behavior is a bug if the step is expected to fail)

tests/acceptance/features/apiProvisioning-v2/resetUserPassword.feature Outdated Show resolved Hide resolved
@saw-jan saw-jan force-pushed the expand-provisioning-tests branch 5 times, most recently from 064c5f5 to 6a18918 Compare January 25, 2021 03:28
dpakach
dpakach reviewed Jan 25, 2021
View reviewed changes
Copy link
Contributor

@dpakach dpakach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good but you have added tests in the middle of the file which messes up the line numbers of other existing tests. That may result in many failures in ocis, so please test this branch with ocis as well.

tests/acceptance/features/apiProvisioning-v2/getUsers.feature Outdated Show resolved Hide resolved
@saw-jan saw-jan requested a review from dpakach January 25, 2021 04:47
@saw-jan saw-jan self-assigned this Jan 25, 2021
Talank
Talank reviewed Jan 25, 2021
View reviewed changes
Copy link
Contributor

@Talank Talank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud
Copy link

sonarcloud bot commented Jan 26, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@individual-it individual-it merged commit 827a4e1 into master Jan 26, 2021
@delete-merged-branch delete-merged-branch bot deleted the expand-provisioning-tests branch January 26, 2021 11:36
@saw-jan saw-jan mentioned this pull request Jan 27, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Talank Talank Talank left review comments

@individual-it individual-it individual-it approved these changes

@phil-davis phil-davis Awaiting requested review from phil-davis

@haribhandari07 haribhandari07 Awaiting requested review from haribhandari07

@kiranparajuli589 kiranparajuli589 Awaiting requested review from kiranparajuli589

@jasson99 jasson99 Awaiting requested review from jasson99

@swoichha swoichha Awaiting requested review from swoichha

@dpakach dpakach Awaiting requested review from dpakach

Assignees

@saw-jan saw-jan

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@saw-jan @individual-it @swoichha @dpakach @Talank