-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tests-Only] Expand API tests for getGroups, getSubAdminGroups and getUserGroups #38330
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix some Then
and And
in the scenarios
tests/acceptance/features/apiProvisioningGroups-v1/getGroups.feature
Outdated
Show resolved
Hide resolved
tests/acceptance/features/apiProvisioningGroups-v1/getUserGroups.feature
Outdated
Show resolved
Hide resolved
tests/acceptance/features/apiProvisioningGroups-v2/getGroups.feature
Outdated
Show resolved
Hide resolved
tests/acceptance/features/apiProvisioningGroups-v2/getUserGroups.feature
Outdated
Show resolved
Hide resolved
4197ac2
to
a44052d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
b0ae006
to
5bfaa2d
Compare
tests/acceptance/features/apiProvisioningGroups-v2/getUserGroups.feature
Outdated
Show resolved
Hide resolved
5bfaa2d
to
a60a5a1
Compare
a60a5a1
to
f3b2733
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to clarify what to do with issue demonstration scenarios of oc10
tests/acceptance/features/apiProvisioningGroups-v1/getGroups.feature
Outdated
Show resolved
Hide resolved
f3b2733
to
98672e1
Compare
98672e1
to
980d35f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now. I rebased and removed the issue tag etc.
This demonstrates the existing oC10 behaviour. Somebody might adjust some subadmin behaviour - see issue owncloud/owncloud-sdk#658
And when that happens they can decide exactly what to adjust in the scenarios tagged issue-owncloud-sdk-658
Kudos, SonarCloud Quality Gate passed! |
Description
expands apiProvisioningGroup tests for ocs v1 and v2 in:
Related Issue
How Has This Been Tested?
Types of changes
Checklist: