Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests-Only] Expand API tests for getGroups, getSubAdminGroups and getUserGroups #38330

Merged
merged 1 commit into from
Jan 28, 2021

Conversation

saw-jan
Copy link
Member

@saw-jan saw-jan commented Jan 22, 2021

Description

expands apiProvisioningGroup tests for ocs v1 and v2 in:

  • getGroups
  • getSubAdminGroups
  • getUserGroups

Related Issue

How Has This Been Tested?

  • test environment: local

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

Copy link
Contributor

@Talank Talank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix some Then and And in the scenarios

@saw-jan saw-jan force-pushed the expand-provisioning-group-tests branch from 4197ac2 to a44052d Compare January 22, 2021 11:10
@saw-jan saw-jan requested a review from Talank January 22, 2021 11:10
Copy link
Contributor

@Talank Talank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@saw-jan saw-jan force-pushed the expand-provisioning-group-tests branch 4 times, most recently from b0ae006 to 5bfaa2d Compare January 25, 2021 05:00
@saw-jan saw-jan self-assigned this Jan 25, 2021
@individual-it
Copy link
Member

something went wrong:
image

but that file is not changed 🤔

Copy link
Member

@individual-it individual-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to clarify what to do with issue demonstration scenarios of oc10

@saw-jan saw-jan force-pushed the expand-provisioning-group-tests branch from f3b2733 to 98672e1 Compare January 28, 2021 04:10
@phil-davis phil-davis force-pushed the expand-provisioning-group-tests branch from 98672e1 to 980d35f Compare January 28, 2021 12:42
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now. I rebased and removed the issue tag etc.
This demonstrates the existing oC10 behaviour. Somebody might adjust some subadmin behaviour - see issue owncloud/owncloud-sdk#658
And when that happens they can decide exactly what to adjust in the scenarios tagged issue-owncloud-sdk-658

@sonarcloud
Copy link

sonarcloud bot commented Jan 28, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis phil-davis merged commit d98b71c into master Jan 28, 2021
@delete-merged-branch delete-merged-branch bot deleted the expand-provisioning-group-tests branch January 28, 2021 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants