Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong link generation for space & share link #4688

Closed
dragonchaser opened this issue Sep 27, 2022 · 1 comment
Closed

Wrong link generation for space & share link #4688

dragonchaser opened this issue Sep 27, 2022 · 1 comment
Assignees
@rhafer
Labels
Priority:p2-high Escalation, on top of current planning, release blocker Type:Bug
Milestone
2.0.0 General Ava...

Comments

@dragonchaser
Copy link
Member

When inviting people to a space there is a bug in the share link that is generated for the email:

ocis/services/notifications/pkg/service/service.go

Line 159 in a552116

shareLink, err := urlJoinPath(e.Executant.Idp, "files/spaces/projects", storagespace.FormatResourceID(*e.ID))

same for shares:

ocis/services/notifications/pkg/service/service.go

Line 272 in a552116

shareLink, err := urlJoinPath(e.Executant.Idp, "files/shares/with-me")

It uses the .Idp url instead of the instance url.
@dragonchaser dragonchaser added Type:Bug Priority:p2-high Escalation, on top of current planning, release blocker labels Sep 27, 2022
@butonic butonic added this to the 2.0.0 General Availability milestone Sep 28, 2022
@rhafer rhafer self-assigned this Sep 29, 2022
@rhafer
Copy link
Contributor

rhafer commented Sep 29, 2022

I'll look into this. As I am working on the other notifications issue already.

rhafer added a commit to rhafer/ocis that referenced this issue Sep 29, 2022
@rhafer
Fix share/space link in notification mail
e934f7b 
Use OCIS_URL as the link base. This change also makes sure that the
top-level OcisURL config value gets a default assigned, even when
OCIS_URL is unset.

Fixes: owncloud#4688
@rhafer rhafer mentioned this issue Sep 29, 2022
Merged
rhafer added a commit to rhafer/ocis that referenced this issue Sep 29, 2022
@rhafer
Fix share/space link in notification mail
95de35e 
Use OCIS_URL as the link base. This change also makes sure that the
top-level OcisURL config value gets a default assigned, even when
OCIS_URL is unset.

Fixes: owncloud#4688
@rhafer rhafer closed this as completed in c6664cf Sep 29, 2022
ownclouders pushed a commit that referenced this issue Sep 29, 2022
@rhafer
commit c6664cf
d0f20be 
Author: Ralf Haferkamp <[email protected]>
Date:   Thu Sep 29 14:59:16 2022 +0200

    Fix share/space link in notification mail

    Use OCIS_URL as the link base. This change also makes sure that the
    top-level OcisURL config value gets a default assigned, even when
    OCIS_URL is unset.

    Fixes: #4688
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rhafer rhafer

Labels
Priority:p2-high Escalation, on top of current planning, release blocker Type:Bug
Projects
Infinite Scale Team Board
Archived in project
Milestone
2.0.0 General Availability
Development

No branches or pull requests
3 participants
@rhafer @butonic @dragonchaser