Multiple fixes for notification service #4714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'ShareCreated' and 'SpaceCreate' events for group shares have an empty GranteeUserID attribute. We need to lookup the GranteeGroup to get the Grantee Name for the notification mail Partial Fix: owncloud#4703
For looking up group members we need to pass an authenticated reva context via the notification interface. We use the share owner's context that we generated when stating the share target. Fixes: owncloud#4703
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
Use OCIS_URL as the link base. This change also makes sure that the top-level OcisURL config value gets a default assigned, even when OCIS_URL is unset. Fixes: owncloud#4688
dragonchaser
approved these changes
Sep 29, 2022
|
Kudos, SonarCloud Quality Gate passed! |
73 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #4703 , #4688