Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Share notifications broken for "group-only" shares #4703

Closed
4 tasks
rhafer opened this issue Sep 28, 2022 · 0 comments · Fixed by #4714
Closed
4 tasks

Share notifications broken for "group-only" shares #4703

rhafer opened this issue Sep 28, 2022 · 0 comments · Fixed by #4714
Assignees
@rhafer
Labels
Priority:p2-high Escalation, on top of current planning, release blocker Type:Bug
Milestone
2.0.0 General Ava...

Comments

@rhafer
Copy link
Contributor

rhafer commented Sep 28, 2022 •
edited
Loading

Describe the bug

When creating sharing a resource with only groups in the sharees list. Multiple things go wrong in the notification service:

  • ocis panics because the notification service calls GetUser() with a nil UserId in the GetUserRequest -> This needs to be fixed in the reva user provider
  • even without the above panic the notification service would not send out a proper notification as it seems to rely on at least one "real" user to be on the sharees list
  • notifications for group shares can't be send as the group lookup is using an un-authenticated context (https://github.com/owncloud/ocis/blob/master/services/notifications/pkg/channels/channels.go#L133)
  • It seems the above points also apply to the SpaceShared events
@rhafer rhafer self-assigned this Sep 28, 2022
@micbar micbar added the Priority:p2-high Escalation, on top of current planning, release blocker label Sep 28, 2022
@micbar micbar added this to the 2.0.0 General Availability milestone Sep 28, 2022
rhafer added a commit to rhafer/ocis that referenced this issue Sep 28, 2022
@rhafer
Fix grantee lookup for ShareCreated event for groups
785e95d 
'ShareCreated' events for group shares have an empty GranteeUserID
attribute. We need to lookup the GranteeGroup to get the Grantee Name
for the notification mail

Partial Fix: owncloud#4703
rhafer added a commit to rhafer/reva that referenced this issue Sep 28, 2022
@rhafer
prevent nil pointer exceptions when requesting user or groups
0f4f8e3 
owncloud/ocis#4703
@rhafer rhafer mentioned this issue Sep 28, 2022
Merged
rhafer added a commit to rhafer/reva that referenced this issue Sep 28, 2022
@rhafer
prevent nil pointer exceptions when requesting user or groups
1d94178 
owncloud/ocis#4703
rhafer added a commit to rhafer/ocis that referenced this issue Sep 29, 2022
@rhafer
Fix grantee lookup for Share/Space Created event for groups
ac52cae 
'ShareCreated' and 'SpaceCreate' events for group shares have an empty
GranteeUserID attribute. We need to lookup the GranteeGroup to get the Grantee
Name for the notification mail

Partial Fix: owncloud#4703
rhafer added a commit to rhafer/ocis that referenced this issue Sep 29, 2022
@rhafer
Fix notifications for group grantees
621079a 
For looking up group members we need to pass an authenticated reva context via
the notification interface. We use the share owner's context that we generated
when stating the share target.

Fixes: owncloud#4703
@rhafer rhafer mentioned this issue Sep 29, 2022
Merged
rhafer added a commit that referenced this issue Sep 29, 2022
@rhafer
Fix grantee lookup for Share/Space Created event for groups
f71f7c7 
'ShareCreated' and 'SpaceCreate' events for group shares have an empty
GranteeUserID attribute. We need to lookup the GranteeGroup to get the Grantee
Name for the notification mail

Partial Fix: #4703
rhafer added a commit that referenced this issue Sep 29, 2022
@rhafer
Fix notifications for group grantees
de15888 
For looking up group members we need to pass an authenticated reva context via
the notification interface. We use the share owner's context that we generated
when stating the share target.

Fixes: #4703
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rhafer rhafer

Labels
Priority:p2-high Escalation, on top of current planning, release blocker Type:Bug
Projects
Infinite Scale Team Board
Archived in project
Milestone
2.0.0 General Availability
Development

Successfully merging a pull request may close this issue.

Multiple fixes for notification service rhafer/ocis
2 participants
@rhafer @micbar