Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci] update web to v5.7.0-rc.11 #4508

Merged
merged 3 commits into from
Sep 8, 2022
Merged

[full-ci] update web to v5.7.0-rc.11 #4508

merged 3 commits into from
Sep 8, 2022

Conversation

kulmann
Copy link
Member

@kulmann kulmann commented Sep 2, 2022

updating web to v5.7.0-rc.11 for the upcoming oCIS v2.0.0-beta.8 release.

@kulmann kulmann force-pushed the update-web-5.7.0-rc.11 branch 2 times, most recently from 545a806 to 363e742 Compare September 5, 2022 11:58
@phil-davis
Copy link
Contributor

CI failed because of owncloud/web#6798 (comment)
https://drone.owncloud.com/owncloud/ocis/15218/70/14

I restarted again!

@phil-davis
Copy link
Contributor

https://drone.owncloud.com/owncloud/ocis/15219/70/14

Checking expected failures in //drone/src/tests/acceptance/expected-failures-webUI-on-OCIS-storage.md
Error: Scenario webUITextEditor/textFile.feature:21 failed but was not expected to fail.
Error: Scenario webUITextEditor/textFile.feature:29 failed but was not expected to fail.
runsh: Total unexpected failed scenarios throughout the test run:
webUITextEditor/textFile.feature:21
webUITextEditor/textFile.feature:29

These failed again - why is that? I will restart and we need to investigate.

@phil-davis phil-davis self-assigned this Sep 6, 2022
@SagarGi
Copy link
Member

SagarGi commented Sep 6, 2022

@phil-davis failed on nightly too. https://drone.owncloud.com/owncloud/ocis/15221/69/14

@phil-davis
Copy link
Contributor

phil-davis commented Sep 6, 2022 •
edited
Loading

@phil-davis failed on nightly too. https://drone.owncloud.com/owncloud/ocis/15221/69/14

That is "good" - at least I know that the problem is not introduced by this PR! But it seems to be happening a lot now. It will be good to investigate again in issue owncloud/web#6798 and see if we can reproduce this somehow.

@micbar
Copy link
Contributor

micbar commented Sep 6, 2022

Needs cs3org/reva#3195 and a reva update

@micbar micbar mentioned this pull request Sep 6, 2022
Closed
29 tasks
@kulmann
Copy link
Member Author

kulmann commented Sep 8, 2022

Rebased, since reva edge was bumped approx. an hour ago.

@sonarcloud
Copy link

sonarcloud bot commented Sep 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

micbar
micbar approved these changes Sep 8, 2022
View reviewed changes
Copy link
Contributor

@micbar micbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uh, big regression with the & character

@kulmann kulmann merged commit dce41c3 into master Sep 8, 2022
@delete-merged-branch delete-merged-branch bot deleted the update-web-5.7.0-rc.11 branch September 8, 2022 12:55
ownclouders pushed a commit that referenced this pull request Sep 8, 2022
@kulmann
commit dce41c3
9f4f6f0 
Merge: 3904635 c10a6f2
Author: Benedikt Kulmann <[email protected]>
Date:   Thu Sep 8 14:55:20 2022 +0200

    Merge pull request #4508 from owncloud/update-web-5.7.0-rc.11

    [full-ci] update web to v5.7.0-rc.11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micbar micbar micbar approved these changes

@C0rby C0rby Awaiting requested review from C0rby

@kobergj kobergj Awaiting requested review from kobergj

Assignees

@phil-davis phil-davis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kulmann @phil-davis @SagarGi @micbar