This repository has been archived by the owner on Jan 3, 2024. It is now read-only.
Create OcContextualHelper component #2064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
lookacat
changed the title
|
For clarification: Of couse slots would be better in most cases but the idea here is to give all information by props so we can create json files with the content of each helper in web. This would mean almost no markup in web, if we used slots it would create markup that is not relevant for web. |
lookacat
force-pushed
the
add-contextual-helper
branch
2 times, most recently
from
712ddc2
to
d704db8
Compare
lookacat
changed the title
pascalwengerter
suggested changes
Apr 12, 2022
changelog/unreleased/enhancement-add-contextual-helper-component
Outdated
Show resolved
Hide resolved
lookacat
force-pushed
the
add-contextual-helper
branch
from
a822009
to
8b9360d
Compare
pascalwengerter
suggested changes
Apr 20, 2022
lookacat
force-pushed
the
add-contextual-helper
branch
from
0b8cb7c
to
be1c9ff
Compare
src/components/atoms/OcContextualHelper/OcContextualHelper.spec.js
Outdated
Show resolved
Hide resolved
|
done :) |
src/components/atoms/OcContextualHelper/OcContextualHelper.spec.js
Outdated
Show resolved
Hide resolved
lookacat
force-pushed
the
add-contextual-helper
branch
2 times, most recently
from
a596785
to
ec5f9ae
Compare
lookacat
force-pushed
the
add-contextual-helper
branch
from
ec5f9ae
to
6e6871a
Compare
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See owncloud/web#6590
Related Issue
Screenshots
Types of changes
Checklist: