Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 5.5.0 #6812

Closed
21 of 25 tasks
fschade opened this issue Apr 26, 2022 · 6 comments · Fixed by #6854
Closed
21 of 25 tasks

Release 5.5.0 #6812

fschade opened this issue Apr 26, 2022 · 6 comments · Fixed by #6854

Comments

@fschade
Copy link
Collaborator

fschade commented Apr 26, 2022 •
edited by pascalwengerter
Loading

Waiting for

Release checklist

  • pin release issue @fschade
  • release & bump ODS if needed
  • release & bump SDK if needed
  • prepare release rc
    • create a branch release-5.5.0 @kulmann
    • update the version in packages/web-integration-oc10/appinfo/info.xml @kulmann
    • update the version in package.json @kulmann
    • update the version in sonar-project.properties @kulmann
    • move changelog/unreleased/* to changelog/VERSION_YYYY-MM-DD @kulmann
    • update the ocis commit id in .drone.env to the most recent one from ocis master (let's see how it goes) @kulmann
    • commit, push and create draft PR for this branch @kulmann
  • create pre release tag v5.5.0-rc.1 from the release branch @kulmann
  • smoke test
    • against oCIS @ScharfViktor
    • against oc10 as sidecar deployment @fschade
    • against oc10 as app installation
    • against oCIS wopi example / app provider
    • against oc10 with OnlyOffice app installed skipped
  • if needed, fix issues or write down known issues
  • update YYYY-MM-DD to current date in changelog/VERSION_YYYY-MM-DD
  • Make sure translations are up to date by updating them in Transifex and restarting translation sync job https://drone.owncloud.com/owncloud/translation-sync/ @pascalwengerter
  • repeat above steps if a new rc is needed
  • Run translations sync job once again
  • go to the releases section and click Draft a new Release. Use v5.5.0 as a tag (the v prefix is important) and 5.5.0 as name and publish it
  • ping in internal #btr channel to create a signed release and ask them to upload it to a) the github release page, b) marketplace.owncloud.com, c) portal.owncloud.com, d) customer.owncloud.com
  • merge release branch back to master (CI must be green)
@fschade fschade pinned this issue Apr 26, 2022
@kulmann kulmann mentioned this issue May 2, 2022
Merged
@lookacat
Copy link
Contributor

lookacat commented May 3, 2022 •
edited by ScharfViktor
Loading

Smoke Testing agains ocis:

SmokeTest against ocis

branch: v5.5.0-rc.1

Case 1: admin share folder(with file) to marie:

Admin:

  • upload big fil 10gb - feels great
  • upload folder with 2000 small files. ! about 4 errors are thrown, after reload page becomes unresponsive for minutes
  • Check pagination, count items per page - 100 files
  • upload folder(drag folder) "folder_to_share" with file.pdf
  • share folder "folder_to_share" to marie with edit right

Marie:

  • accept "folder_to_share" (Header/Table looks weird and far down)
  • rename "folder_to_share"
  • upload new file "file.txt" to "folder_to_share" (admin see new file)
  • open image
  • rename image.jpg (use rigth click) (admin see that file changed name)

Admin:

  • add new file.jpeg to "folder_to_share"
  • add file format drawio (marie can open in Draw.io and can edit)
  • move file.pdf to root "personal" (marie can not see file.pdf)
  • [/] add new "file.txt" create new version. (use drag and drop) (!!!Drag and Drop is broken, no effekt on hover)
  • open txt file in markdown-editor. Change and save. (Can't open it in markdown)

Marie:

  • 🚫 can download both versions (!error 501)
  • restore old version

Admin:

  • change share "folder_to_share" from "edit" to "viewer" (marie cannot rename/move/delete/download file in folder and cannot create new document in the folder)

Marie:

  • decline folder (removed from shares folder)
  • accept again

Admin:

  • delete folder "folder_to_share" (removed from shared with me, removed from Marie)

Case 2: admin share file to marie:

Admin:

  • upload file.jpeg
  • share file.jpeg to marie with rigth viewer (use main menu. find marie by email [email protected])

Marie:

  • accept file (marie can open/download/copy file but cannot delete/move/rename)
  • copy file to "/"
  • open file in Mediaviewer
  • download file

Admin:

  • share "file.txt" with edit right with "radium-lovers" group

Marie:

  • marie can see file while she is member of the group
  • rename file (🚫admin don't see)
  • change content of the file (can see new version)

Admin:

  • unshare "file.jpeg" (marie cannot see "file.jpeg" in Shares/Shared for me but see the copied file)

Case 3: admin create public links to folder

Admin:

  • create folder "for upload"
  • add link with name "to_upload" with role "Uploader" with pass and expiration date
  • open link (can only upload)
  • upload file (admin can see new file)
  • change share "for upload" from "Uploader" to "edit"
  • admin add new file to "for upload"
  • refresh link (file exist)
  • admin change pass (refresh link has to type new pass)

Case 4: admin create link to file

Admin:

  • create file png
  • add link with main menu
  • open link(can open, download, see) in the incognito tab
  • change link, add pass
  • refresh page (input pass)
  • delete link
  • refresh page (resource not found)
  • delete file
  • restore
  • delete
  • Empty trash

Case 5: space story:

Admin gives to richard role "Space Admin":

Richard:
🚫 - [ ] create space - cannot create space with "Space Admin" permissions

Admin:

  • create space
    🚫 - [ ] add space image - doesn't work/ PROPFIND 404. Image is not displayed
  • add subtitle "for test"
  • edit description
  • try to upload file (more 1 Gb) - (507- Insufficient Storage)
  • increase quota to 5Gb and try again
  • delete file
  • add member Marie with edit role
  • add member Einstein with viewer role

Marie:

  • can see space without accepting
  • change image and description
  • can upload file/folder and create file and folder
  • cannot create resource sharing and space sharing
  • can see deleted files and can restore files from trash
  • cannot disable space

Einstein:

  • can see space without accepting
  • cannot change image and description
  • cannot upload file/folder and create file and folder
  • cannot create resource sharing and space sharing
  • can see deleted files and cannot restore files from trash
  • cannot disable space

Admin change Einstein role to manager:

Einstein:

  • can see space without accepting
  • can change image and description
  • can upload file/folder and create file and folder
  • can create resource sharing and space sharing
  • can see deleted files and can restore files from trash
  • can change admins role and delete share
  • can disable and delete space

Case 6: user managment

Admin:

  • create new account "tom"
  • change language
  • admin blocks and deletes user "tom" - not impemented

Findings:

@ScharfViktor
Copy link
Contributor

start ocis via docker-compose doesn't work:
web_ocis exited with code 1

jwt_secret has not been set properly in your config for ocis. Make sure your /etc/ocis config contains the proper values (e.g. by running ocis init or setting it manually in the config/corresponding environment variable).

we need add ocis init

@kulmann
Copy link
Member

kulmann commented May 3, 2022 •
edited
Loading

start ocis via docker-compose doesn't work: web_ocis exited with code 1

jwt_secret has not been set properly in your config for ocis. Make sure your /etc/ocis config contains the proper values (e.g. by running ocis init or setting it manually in the config/corresponding environment variable).

we need add ocis init

fixed in #6860
I have rebased this branch already

@ScharfViktor
Copy link
Contributor

fixed in #6860 I have rebased this branch already

I've already tested. It works. thanks)

@micbar micbar mentioned this issue May 9, 2022
Closed
45 tasks
@kulmann
Copy link
Member

kulmann commented Jun 20, 2022

Smoke test v5.5.0-rc.10 (in spe, built it from release branch) against oc10 app

  • ✔️ as gunter - upload arch/mips folder from linux kernel (1801 files)
    - via drag and drop folder upload works
    - via folder upload button works

  • ✔️ as gunter - share the folder to alice as viewer

  • ✔️ as alice - share is already accepted. declining and accepting again works as expected (buttons in shared with me table, batch action, right sidebar)

  • ✔️ as alice - try do delete file from shared folder
    - individual delete action not visible, good
    - batch delete action not visible, good
    - context menu action not visible, good

  • ✔️ as alice - try to add file
    - not possible (which is expected)
    - drag & drop upload handle it with an error (which is good)

  • ❌ as alice - copy 16 folders from share to home (via location picker)

    • no visible feedback that it's in progress
    • UI still weirdly usable, ended up in an active upload drop zone. Needed a page reload to be usable again.

  • ✔️ as alice - copy 16 folders from share to home (via keyboard action)

  • ✔️ as gunter - add new file to share

  • ✔️ as alice - receive new file in existing share

  • ✔️ as gunter - unshare folder from shared with others

  • ✔️ as alice - try to revisit old share

    • shows resource not found upon page reload, good
    • going back to All files or Shared with me doesn't list the share anymore, good

  • ✔️ as gunter - share folder with alice again, but as editor
    - setting and removing an expiration date work as expected, good

  • ✔️ as alice - rename a file

    • via right sidebar, works, good
    • via context menu, works, good

  • ✔️ as gunter - add file

  • ✔️ as alice - delete file

    • via right sidebar, works, good
    • via context menu, works, good
    • via batch action, works, good

  • ✔️ as alice - create public link on any folder

  • ✔️ as alice delete file and recover it

  • ✔️ as alice create version of textfile

  • ✔️ as alice view version history of text file

  • ✔️ as alice download newest version of text file

  • ✔️ download older version of text file

  • ✔️ restore older version of text file

    • no visible feedback about the success
    • preview is not updated

  • ✔️ as alice - upload avatar in classic UI

    • see own avatar in top bar (far right)
    • login as gunter, having a share with alice
      • shared with others page loads
      • avatar of alice is not shown (bad)

  • ✔️ as alice, move a file into subfolder via drag and drop

  • ✔️ as alice, move multiple files & folders into subfolder via drag and drop

  • ✔️ as alice, navigate into a folder, open right sidebar without selection, share current folder with gunter

New findings

  • shared with others page doesn't show avatars anymore

Resolved issues

  • upload issues regarding slow/laggy web ui and non-sticky progress bar are resolved
  • sharing issue where sharing during in-progress uploads was not possible is resolved
  • trying to upload a file in a read only share doesn't open the file in a new tab anymore but shows an upload error instead
  • UX for copy/move is good with keyboard actions. location picker issues remain.

@ScharfViktor
Copy link
Contributor

ScharfViktor commented Jun 20, 2022 •
edited
Loading

Smoke web agains ocis

branch: v5.5.0-rc.10

Case 1: admin share folder(with file) to marie:

Admin:

Marie:

  • accept "folder_to_share"
  • rename "folder_to_share" - cannot rename folder in new implementation
  • upload new file "file.txt" to "folder_to_share" (admin see new file)
  • open pdf file
  • rename file.pdf (use rigth click) (admin see that file changed name)

Admin:

  • add new file.jpeg to "folder_to_share"
  • move file.pdf to root "personal" (marie can not see file.pdf)
  • add new "file.txt" create new version. (use drag and drop)
  • open txt file in markdown-editor. Change and save.

Marie:

  • can download both versions
  • restore old version

Admin:

  • change share "folder_to_share" from "edit" to "viewer" (marie cannot rename/move/delete/download file in folder and cannot create new document in the folder)

Marie:

  • decline folder (removed from shares folder)
  • accept again

Admin:

  • delete folder "folder_to_share" (removed from shared with me, removed from Marie)

Case 2: admin share file to marie:

Admin:

  • upload file.jpeg
  • share file.jpeg to marie with rigth viewer (use main menu. find marie by email [email protected])

Marie:

  • accept file (marie can open/download/copy file but cannot delete/move/rename)
  • open file in Mediaviewer
  • download file

Admin:

  • share share "file.txt" with edit right

Marie:

  • rename file - cannot rename in new implementation
  • change content of the file (can see new version)

Admin:

  • unshare "file.jpeg" (marie cannot see "file.jpeg")

Case 3: admin create public links to folder

Admin:

  • create folder "for upload"
  • add link with name "to_upload" with role "Uploader" with pass and expiration date
  • open link (can only upload)
  • upload file (admin can see new file)
  • change share "for upload" from "Uploader" to "edit"
  • admin add new file to folder "for upload"
  • refresh link (file exist)
  • admin change pass (refresh link has to type new pass)

Case 4: admin create link to file

Admin:

  • create file png
  • add link with main menu
  • open link(can open, download, see) in the incognito tab
  • change link, add pass
  • refresh page (input pass)
  • delete link
  • refresh page (resource not found)
  • delete file
  • restore
  • delete
  • Empty trash

Case 5: space story:

Katherine:

  • create space
  • add space image
  • add subtitle "for test"
  • edit description
  • try to upload file (more 1 Gb)
  • increase quota to 5Gb and try again
  • delete file
  • add member Marie with edit role
  • add member Einstein with viewer role

Marie:

  • can see space without accepting
  • change image and description
  • can upload file/folder and create file and folder
  • cannot create resource sharing and space sharing
  • can see deleted files and can restore files from trash
  • cannot disable space

Einstein:

  • can see space without accepting
  • cannot change image and description
  • cannot upload file/folder and create file and folder
  • cannot create resource sharing and space sharing
  • can see deleted files and cannot restore files from trash
  • cannot disable space

Katherine change Einstein role to manager - is not working yet. It relates to re-sharing

Case 6: create new user via accounts:

Admin (test via api):

  • create new account "tom" use graph Api
  • create new group
  • share folder with group
  • change language
  • delete users

Remarks:

@pascalwengerter pascalwengerter unpinned this issue Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[full-ci] Prepare release 5.5.0 owncloud/web
4 participants
@lookacat @kulmann @fschade @ScharfViktor