Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci] Bugfix: Spaces Contextmenu trigger id isn't valid #6848

Merged
merged 2 commits into from
May 2, 2022
Merged

[full-ci] Bugfix: Spaces Contextmenu trigger id isn't valid #6848

merged 2 commits into from
May 2, 2022

Conversation

lookacat
Copy link
Contributor

@lookacat lookacat commented Apr 29, 2022 •
edited
Loading

Description

See #6845

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented Apr 29, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@lookacat lookacat mentioned this pull request Apr 29, 2022
Closed
@lookacat lookacat force-pushed the bufix-spaces-contextmenu-id branch from 75a4227 to cb18898 Compare April 29, 2022 12:56
@lookacat lookacat marked this pull request as ready for review April 29, 2022 12:59
@lookacat lookacat force-pushed the bufix-spaces-contextmenu-id branch from cb18898 to 29fc948 Compare April 29, 2022 13:12
kulmann
kulmann approved these changes Apr 29, 2022
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ownclouders
Copy link
Contributor

ownclouders commented Apr 29, 2022 •
edited
Loading

Results for oCISTrashbinUploadMoveJourney https://drone.owncloud.com/owncloud/web/25111/70/1
The following scenarios passed on retry:

  • webUITrashbinRestore/trashbinRestore.feature:115
  • webUITrashbinRestore/trashbinRestore.feature:279
💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUITrashbinDelete-trashbinDelete_feature-L105.png

webUITrashbinDelete-trashbinDelete_feature-L105.png

@kulmann kulmann force-pushed the bufix-spaces-contextmenu-id branch 2 times, most recently from 8196e4a to a9ce3f8 Compare May 2, 2022 10:52
@kulmann kulmann changed the title Bugfix: Spaces Contextmenu trigger id isn't valid [full-ci] Bugfix: Spaces Contextmenu trigger id isn't valid May 2, 2022
@kulmann kulmann force-pushed the bufix-spaces-contextmenu-id branch from a9ce3f8 to 7bedd3f Compare May 2, 2022 12:49
@sonarcloud
Copy link

sonarcloud bot commented May 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

60.0% 60.0% Coverage
0.0% 0.0% Duplication

@kulmann
Copy link
Member

kulmann commented May 2, 2022

Force merging with two flaky tests 👀

@kulmann kulmann merged commit fa7ab3f into master May 2, 2022
@delete-merged-branch delete-merged-branch bot deleted the bufix-spaces-contextmenu-id branch May 2, 2022 14:01
This was referenced May 2, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

@pascalwengerter pascalwengerter Awaiting requested review from pascalwengerter

@fschade fschade Awaiting requested review from fschade

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Open expiration Datepicker on public link creation flickers
3 participants
@lookacat @ownclouders @kulmann