Changing role of a public link with expiry date doesn't work

[SwikritiT]

Steps to reproduce

1. Create a public link of a resource with an expiry date
2. Now try to change the role of the previously created public link

Expected behaviour

The role should be changed with the message Link was updated successfully

Actual behavior

Two messages Failed to update link and Link was updated successfully are displayed but the role is not updated. The behavior is the same for both backends

publiclink.mp4

[SwikritiT]

The test in this PR is failing because of this issue: #6557
link to build: https://drone.owncloud.com/owncloud/web/25145/11/18

[pascalwengerter]

This issue isn't about a problem in master but about something blocking your PR, or am I reading this wrong?

[SwikritiT]

This issue isn't about a problem in master but about something blocking your PR, or am I reading this wrong?

It is an issue in master. In my PR I was writing new tests for changing the role and this was caught. I can reproduce it in my local setup as well.

[pascalwengerter]

I can't from the steps you outlined above, also we do have acceptance tests on master that pass for this behaviour.

Could you narrow it down whether it Is it related to the link being password-protected or having an expiry date? A freshly created public link can have role changes without errrors

[SwikritiT]

I can't from the steps you outlined above, also we do have acceptance tests on master that pass for this behaviour.

Could you narrow it down whether it Is it related to the link being password-protected or having an expiry date? A freshly created public link can have role changes without errrors

It's because of the expiry date. Can you check again with the expiry date?

[pascalwengerter]

Thank you for raising it and further investigation, I'll take care of this issue

[ScharfViktor]

I reproduced it. Description is here: #6865