Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add project spaces e2e tests #6711

Merged
merged 3 commits into from
Apr 1, 2022
Merged

Add project spaces e2e tests #6711

merged 3 commits into from
Apr 1, 2022

Conversation

fschade
Copy link
Collaborator

@fschade fschade commented Apr 1, 2022

Description

First iteration on adding e2e tests for the project spaces, the idea was to keep everything compatible and only write new actions when needed.

if ci and reviewers are happy... ready to be merged.

Please see:

  • add project spaces tests, pages and actions
  • add dedicated key for the internal object stores (set, get)
  • add store and environment for spaces
  • get rid of external store usage in favor of environments
  • add tests-selectors in components and views
  • update shared actions to work inside project spaces
  • differentiate between oc10, oCis and global tests via glob
  • cleanup some internals like interface over type
  • refactor api package actions to always contain a user
  • always use join for api calls
  • remove versionApi parameter from the api request method to freely choose the endpoint
  • add settings endpoint to the api
  • add graph endpoints to the api

Related Issue

Motivation and Context

increase e2e test coverage

How Has This Been Tested?

  • writing tests that test tests.... ;)

Types of changes

  • Tests

Checklist:

  • Code changes
  • E2E tests added

Open tasks:

  • see if ci is happy, then good to go

@fschade fschade self-assigned this Apr 1, 2022
@update-docs
Copy link

update-docs bot commented Apr 1, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@fschade
Copy link
Collaborator Author

fschade commented Apr 1, 2022

Cc.: @ScharfViktor

add dedicated key for the internal object stores (set, get)
add store and environment for spaces
get rid of external store usage in favor of environments
add tests-selectors in components and views
update shared actions to work inside project spaces
differentiate between oc10, oCis and global tests via glob
cleanup some internals like interface over type
refactor api package actions to always contain a user
always use join for api calls
remove versionApi parameter from the api request method to freely choose the endpoint
add settings endpoint to the api
add graph endpoints to the api
@sonarcloud
Copy link

sonarcloud bot commented Apr 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E tests are green and code looks fine, thanks for the huge effort!

@pascalwengerter pascalwengerter merged commit 7b78f56 into master Apr 1, 2022
@delete-merged-branch delete-merged-branch bot deleted the spaces-e2e branch April 1, 2022 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

E2E tests for spaces
3 participants