-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add project spaces e2e tests #6711
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
Cc.: @ScharfViktor |
add dedicated key for the internal object stores (set, get) add store and environment for spaces get rid of external store usage in favor of environments add tests-selectors in components and views update shared actions to work inside project spaces differentiate between oc10, oCis and global tests via glob cleanup some internals like interface over type refactor api package actions to always contain a user always use join for api calls remove versionApi parameter from the api request method to freely choose the endpoint add settings endpoint to the api add graph endpoints to the api
Results for e2e-tests oC10 https://drone.owncloud.com/owncloud/web/24351/10/1 💥 To see the trace, please open the link in the console ...
npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/24351/tracing/alice-can-share-this-weeks-meal-plan-with-all-parents-alice-2022-4-1-02-44-22.zipnpx playwright show-trace https://cache.owncloud.com/public/owncloud/web/24351/tracing/alice-can-share-this-weeks-meal-plan-with-all-parents-brian-2022-4-1-02-44-49.zipnpx playwright show-trace https://cache.owncloud.com/public/owncloud/web/24351/tracing/file-alice-2022-4-1-02-42-38.zipnpx playwright show-trace https://cache.owncloud.com/public/owncloud/web/24351/tracing/file-brian-2022-4-1-02-42-46.zipnpx playwright show-trace https://cache.owncloud.com/public/owncloud/web/24351/tracing/folder-alice-2022-4-1-02-41-07.zipnpx playwright show-trace https://cache.owncloud.com/public/owncloud/web/24351/tracing/folder-brian-2022-4-1-02-41-17.zip |
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E2E tests are green and code looks fine, thanks for the huge effort!
Description
First iteration on adding e2e tests for the project spaces, the idea was to keep everything compatible and only write new actions when needed.
if ci and reviewers are happy... ready to be merged.
Please see:
Related Issue
Motivation and Context
increase e2e test coverage
How Has This Been Tested?
Types of changes
Checklist:
Open tasks: