Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only] Adds e2e test for changing public link role #6557

Merged
merged 2 commits into from
May 5, 2022
Merged

[tests-only] Adds e2e test for changing public link role #6557

merged 2 commits into from
May 5, 2022

Conversation

SwikritiT
Copy link
Contributor

@SwikritiT SwikritiT commented Mar 9, 2022 •
edited
Loading

Description

Adds step for: Alice changes role to editor, change expiration date

Related Issue

Motivation and Context

How Has This Been Tested?

  • local
  • CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • e2e tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@SwikritiT SwikritiT self-assigned this Mar 9, 2022
@update-docs
Copy link

update-docs bot commented Mar 9, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@ownclouders
Copy link
Contributor

Results for e2e-tests oCIS https://drone.owncloud.com/owncloud/web/23424/11/1

💥 To see the trace, please open the link in the console ...

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/23424/tracing/alice-shares-folder-with-file-to-brian-alice-2022-3-9-09-51-55.zip

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/23424/tracing/alice-shares-folder-with-file-to-brian-brian-2022-3-9-09-52-08.zip

@SwikritiT SwikritiT changed the title Add test for changing role [tests-only] Adds e2e test for changing role Mar 16, 2022
@SwikritiT SwikritiT mentioned this pull request Mar 22, 2022
Closed
13 tasks
@SwikritiT
Copy link
Contributor Author

This PR needs to be merged first #6541

@SwikritiT SwikritiT changed the base branch from master to downloadPubicLinkFiles March 22, 2022 10:18
@SwikritiT SwikritiT changed the title [tests-only] Adds e2e test for changing role [tests-only] Adds e2e test for editing public link Mar 22, 2022
pascalwengerter
pascalwengerter reviewed Mar 22, 2022
View reviewed changes
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failed with linting errors. Also please wait for @fschade's feedback (he's not in the office today) on E2E tests before merging

fschade
fschade requested changes Mar 24, 2022
View reviewed changes
Copy link
Collaborator

@fschade fschade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please see comments, thanks for you contribution.

tests/e2e/cucumber/features/integrations/link.feature Outdated Show resolved Hide resolved
tests/e2e/support/objects/app-files/link/actions.ts Outdated Show resolved Hide resolved
tests/e2e/support/objects/app-files/link/index.ts Outdated Show resolved Hide resolved
@SwikritiT SwikritiT force-pushed the downloadPubicLinkFiles branch 2 times, most recently from 0215528 to 2e281d2 Compare April 1, 2022 06:55
@fschade fschade mentioned this pull request Apr 1, 2022
Merged
4 tasks
@SwikritiT SwikritiT requested a review from fschade April 4, 2022 04:20
@ownclouders
Copy link
Contributor

ownclouders commented Apr 4, 2022 •
edited
Loading

Results for e2e-tests oC10 https://drone.owncloud.com/owncloud/web/25145/11/1

💥 To see the trace, please open the link in the console ...

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/25145/tracing/public-link-alice-2022-5-3-07-35-47.zip

@SwikritiT SwikritiT force-pushed the downloadPubicLinkFiles branch 2 times, most recently from 3c09bcc to fccfcc6 Compare April 11, 2022 04:19
@SwikritiT SwikritiT force-pushed the downloadPubicLinkFiles branch 3 times, most recently from 1e268dc to b05f23d Compare April 13, 2022 06:43
@SwikritiT SwikritiT force-pushed the downloadPubicLinkFiles branch 2 times, most recently from 175e544 to ccd6acf Compare April 25, 2022 04:02
@SwikritiT SwikritiT force-pushed the downloadPubicLinkFiles branch 2 times, most recently from a72fb45 to 4db25e8 Compare April 29, 2022 05:41
@fschade
Copy link
Collaborator

fschade commented Apr 29, 2022

@SwikritiT can you rebase please

@delete-merged-branch delete-merged-branch bot deleted the branch master April 29, 2022 09:26
@pascalwengerter
Copy link
Contributor

@SwikritiT can you rebase please

Just merged #6541 so rebasing should be simpler (I hope 😬 )

@pascalwengerter
Copy link
Contributor

Also, please use the "Squash and merge" option here (or squash commits locally while rebasing)

@SwikritiT SwikritiT changed the base branch from downloadPubicLinkFiles to master April 29, 2022 12:04
@SwikritiT SwikritiT changed the title [tests-only] Adds e2e test for editing public link [tests-only] Adds e2e test for changing public link role Apr 29, 2022
@SwikritiT SwikritiT force-pushed the changeRole branch 2 times, most recently from bda203a to ee1a75c Compare May 3, 2022 07:20
@SwikritiT SwikritiT mentioned this pull request May 3, 2022
Closed
@SwikritiT SwikritiT marked this pull request as ready for review May 4, 2022 11:38
@sonarcloud
Copy link

sonarcloud bot commented May 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

fschade
fschade approved these changes May 5, 2022
View reviewed changes
Copy link
Collaborator

@fschade fschade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎸 Thanks for taking care

@fschade fschade merged commit d4596c0 into master May 5, 2022
@delete-merged-branch delete-merged-branch bot deleted the changeRole branch May 5, 2022 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascalwengerter pascalwengerter pascalwengerter left review comments

@fschade fschade fschade approved these changes

@SagarGi SagarGi Awaiting requested review from SagarGi

@saw-jan saw-jan Awaiting requested review from saw-jan

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

@grgprarup grgprarup Awaiting requested review from grgprarup

@kiranparajuli589 kiranparajuli589 Awaiting requested review from kiranparajuli589

Assignees

@SwikritiT SwikritiT

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SwikritiT @ownclouders @fschade @pascalwengerter @kiranparajuli589