Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci] Fix public link edit #6867

Merged
merged 1 commit into from
May 4, 2022
Merged

[full-ci] Fix public link edit #6867

merged 1 commit into from
May 4, 2022

Conversation

kulmann
Copy link
Member

@kulmann kulmann commented May 4, 2022

Description

Fix expiration date conversion when editing public links with expiry date.

Related Issue

Motivation and Context

Hardening

How Has This Been Tested?

  • acceptance tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@ownclouders
Copy link
Contributor

Results for oCISSharingAutocompletion https://drone.owncloud.com/owncloud/web/25253/63/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingAutocompletion-shareAutocompletion_feature-L182.png

webUISharingAutocompletion-shareAutocompletion_feature-L182.png

webUISharingAutocompletion-shareAutocompletion_feature-L56.png

webUISharingAutocompletion-shareAutocompletion_feature-L56.png

webUISharingAutocompletion-shareAutocompletion_feature-L66.png

webUISharingAutocompletion-shareAutocompletion_feature-L66.png

💥 The acceptance tests pipeline failed. The build has been cancelled.

@sonarcloud
Copy link

sonarcloud bot commented May 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kulmann kulmann changed the title Fix public link edit [full-ci] Fix public link edit May 4, 2022
@kulmann kulmann merged commit 52e052c into master May 4, 2022
@delete-merged-branch delete-merged-branch bot deleted the fix-public-link-edit branch May 4, 2022 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JammingBen JammingBen JammingBen approved these changes

@AlexAndBear AlexAndBear AlexAndBear approved these changes

@pascalwengerter pascalwengerter Awaiting requested review from pascalwengerter

@fschade fschade Awaiting requested review from fschade

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Changing role of a public link with expiry date doesn't work
4 participants
@kulmann @ownclouders @AlexAndBear @JammingBen