Merge pull request #1168 from majestrate/inter-node-commit-fixes-2020…

…-03-07 Dont rely on operator[] side effects
oxen-io · Mar 11, 2020 · ec2f691 · ec2f691
2 parents ac80357 + 7ba30ee
commit ec2f691
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 13 deletions.
diff --git a/llarp/link/link_manager.cpp b/llarp/link/link_manager.cpp
@@ -146,11 +146,10 @@ namespace llarp
       return;
 
     util::Lock l(_mutex);
-
-    m_PersistingSessions[remote] =
-        std::max(until, m_PersistingSessions[remote]);
-    LogDebug("persist session to ", remote, " until ",
-             m_PersistingSessions[remote].count());
+    auto &curr = m_PersistingSessions[remote];
+    if(until > curr)
+      curr = until;
+    LogDebug("persist session to ", remote, " until ", curr - time_now_ms());
   }
 
   void
@@ -307,7 +306,6 @@ namespace llarp
           auto link = GetLinkWithSessionTo(itr->first);
           if(link)
           {
-            LogDebug("keepalive to ", itr->first);
             link->KeepAliveSessionTo(itr->first);
           }
           else

diff --git a/llarp/link/server.cpp b/llarp/link/server.cpp
@@ -267,7 +267,11 @@ namespace llarp
     {
       Lock_t l(m_AuthedLinksMutex);
       if(m_AuthedLinks.count(rc.pubkey) >= MaxSessionsPerKey)
+      {
+        LogDebug("Too many links to ", RouterID{rc.pubkey},
+                 ", not establishing another one");
         return false;
+      }
     }
     llarp::AddressInfo to;
     if(!PickAddress(rc, to))
@@ -276,7 +280,12 @@ namespace llarp
     {
       Lock_t l(m_PendingMutex);
       if(m_Pending.count(addr) >= MaxSessionsPerKey)
+      {
+        LogDebug("Too many pending connections to ", addr,
+                 " while establishing to ", RouterID{rc.pubkey},
+                 ", not establishing another");
         return false;
+      }
     }
     std::shared_ptr< ILinkSession > s = NewOutboundSession(rc, to);
     if(PutSession(s))
@@ -385,7 +394,10 @@ namespace llarp
     while(itr != range.second)
     {
       if(itr->second->ShouldPing())
+      {
+        LogDebug("keepalive to ", remote);
         itr->second->SendKeepAlive();
+      }
       ++itr;
     }
   }

diff --git a/llarp/link/server.hpp b/llarp/link/server.hpp
@@ -69,9 +69,6 @@ namespace llarp
     bool
     HasSessionTo(const RouterID& pk);
 
-    bool
-    HasSessionVia(const Addr& addr);
-
     void
     ForEachSession(std::function< void(const ILinkSession*) > visit,
                    bool randomize = false) const EXCLUDES(m_AuthedLinksMutex);

diff --git a/llarp/net/net_addr.cpp b/llarp/net/net_addr.cpp
@@ -379,11 +379,13 @@ namespace llarp
   bool
   Addr::operator==(const Addr& other) const
   {
-    if(af() == AF_INET && other.af() == AF_INET)
-      return port() == other.port() && addr4()->s_addr == other.addr4()->s_addr;
+    if(af() != other.af() || port() != other.port())
+      return false;
 
-    return af() == other.af() && memcmp(addr6(), other.addr6(), 16) == 0
-        && port() == other.port();
+    if(af() == AF_INET)
+      return addr4()->s_addr == other.addr4()->s_addr;
+
+    return memcmp(addr6(), other.addr6(), 16) == 0;
   }
 
   Addr&