Dont rely on operator[] side effects #1168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majestrate
force-pushed
the
inter-node-commit-fixes-2020-03-07
branch
from
0e6f286
to
7d331e3
Compare
notlesh
reviewed
Mar 11, 2020
llarp/messages/relay_commit.cpp
Outdated
| // persist session to downstream until path expiration | ||
| self->context->Router()->PersistSessionUntil( | ||
| self->hop->info.downstream, self->hop->ExpireTime() + 10s); | ||
| self->hop->info.downstream, now + path::default_lifetime); | ||
| // put hop |
There was a problem hiding this comment.
now + path::default_lifetime may way overshoot the actual remaining life of a path, although this is probably harmless
majestrate
force-pushed
the
inter-node-commit-fixes-2020-03-07
branch
from
7d331e3
to
7ba30ee
Compare
jagerman
approved these changes
Mar 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.