Empty tx warnings #1563
Merged
Empty tx warnings #1563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some node on the network apparently has a corrupted DB and is spewing empty tx blobs onto the network. Detect such a case rather than broadcasting broken empty txes.
If on_transaction_relayed fails to parse, it returns a null_hash, but that wasn't being detected here. Also eliminates calling `on_transaction_relayed(tx_blob)` twice.
If we pass the blob into parse_and_validate_tx_from_blob we get `deserialization or varint failed` error logs, which are harmless bug annoying. This catches the empty tx blob case earlier and logs at a lesser severity.
jagerman
force-pushed
the
empty-tx-warnings
branch
from
45197b8
to
b39a118
Compare
tewinget
reviewed
Jun 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a node on the network broadcasting empty transactions to other nodes; when they receive it, they log an error and then disconnect from the spewer.
Ultimately I think this can only happen if that node has a corrupted database; that is detected here to not send junk onto the network in such a case.
In tracking this down I noticed some other minor things, collected here.