Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty tx warnings #1563

Merged
merged 3 commits into from
Jun 13, 2022
Merged

Empty tx warnings #1563

merged 3 commits into from
Jun 13, 2022

Commits on Jun 1, 2022

  1. Fail if tx blob is empty 

    Some node on the network apparently has a corrupted DB and is spewing
empty tx blobs onto the network.  Detect such a case rather than
broadcasting broken empty txes.
    @jagerman
    jagerman committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    a6157fe View commit details
    Browse the repository at this point in the history

  2. Detect on_transaction_relayed failure 

    If on_transaction_relayed fails to parse, it returns a null_hash, but
that wasn't being detected here.

Also eliminates calling `on_transaction_relayed(tx_blob)` twice.
    @jagerman
    jagerman committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    4d91082 View commit details
    Browse the repository at this point in the history

  3. Detect and don't try to parse empty txes 

    If we pass the blob into parse_and_validate_tx_from_blob we get
`deserialization or varint failed` error logs, which are harmless bug
annoying.  This catches the empty tx blob case earlier and logs at a
lesser severity.
    @jagerman
    jagerman committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    b39a118 View commit details
    Browse the repository at this point in the history