-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump hyper-rustls from 0.25.0 to 0.27.3 #1110
base: main
Are you sure you want to change the base?
Conversation
Bumps [hyper-rustls](https://github.com/rustls/hyper-rustls) from 0.25.0 to 0.27.3. - [Release notes](https://github.com/rustls/hyper-rustls/releases) - [Commits](rustls/hyper-rustls@v/0.25.0...v/0.27.3) --- updated-dependencies: - dependency-name: hyper-rustls dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
0f18ee1
to
aeb7d64
Compare
@dependabot recreate |
aeb7d64
to
05630e6
Compare
Bumps [hyper-rustls](https://github.com/rustls/hyper-rustls) from 0.25.0 to 0.27.3. - [Release notes](https://github.com/rustls/hyper-rustls/releases) - [Commits](rustls/hyper-rustls@v/0.25.0...v/0.27.3) --- updated-dependencies: - dependency-name: hyper-rustls dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
05630e6
to
b558b82
Compare
…decomputer/dropshot into dependabot/cargo/hyper-rustls-0.27.3
This turns out to be a broken on illumos--interesting! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I imagine we'll want to test that omicron works at all with this stuff rather than landing in a spot where dropshot has a required dependency that's broken for us
@@ -29,7 +29,7 @@ indexmap = "2.5.0" | |||
multer = "3.1.0" | |||
paste = "1.0.15" | |||
percent-encoding = "2.3.1" | |||
rustls = "0.22.4" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these remove the default dependency on aws-lc-rs... which does not build on illumos
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add a comment here explaining why we're disabling this? Whether it's the short-term reason that aws-lc-rs doesn't build on illumos or a long-term preference to avoid it.
@@ -93,7 +93,7 @@ anyhow = "1.0.89" | |||
async-channel = "2.3.1" | |||
buf-list = "1.0.3" | |||
expectorate = "1.1.0" | |||
hyper-rustls = "0.26.0" | |||
hyper-rustls = { version = "0.27.3", default-features = false, features = ["http1", "ring"] } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this adds what we need for testing across platforms
From offline discussion I gathered a bit more context I wanted to leave here for the record:
|
@@ -29,7 +29,7 @@ indexmap = "2.5.0" | |||
multer = "3.1.0" | |||
paste = "1.0.15" | |||
percent-encoding = "2.3.1" | |||
rustls = "0.22.4" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add a comment here explaining why we're disabling this? Whether it's the short-term reason that aws-lc-rs doesn't build on illumos or a long-term preference to avoid it.
@@ -42,7 +42,7 @@ slog-async = "2.8.0" | |||
slog-bunyan = "2.5.0" | |||
slog-json = "2.6.1" | |||
slog-term = "2.9.1" | |||
tokio-rustls = "0.25.0" | |||
tokio-rustls = { version = "0.26.0", default-features = false } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another comment here maybe?
@@ -93,7 +93,7 @@ anyhow = "1.0.89" | |||
async-channel = "2.3.1" | |||
buf-list = "1.0.3" | |||
expectorate = "1.1.0" | |||
hyper-rustls = "0.26.0" | |||
hyper-rustls = { version = "0.27.3", default-features = false, features = ["http1", "ring"] } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another comment here maybe?
We need one of the crypto algorithms enabled by default or else consumers who don't have rustls as an explicit dep will encounter a runtime failure |
Bumps hyper-rustls from 0.25.0 to 0.27.3.
Release notes
Sourced from hyper-rustls's releases.
... (truncated)
Commits
dc54bc0
Bump version to 0.27.3a1d9263
Import std::io directly6d1267c
Avoid io::Result type alias139550b
Upgrade to rustls-native-certs 0.8516e3ac
Alphabetically sort features3a4d5d7
Move features before dependenciesf8c2036
chore: sort features1d57d93
enablerustls-platform-verifier
for docs.rsa6a5687
Take impl Into<Arc> in connector builderb4f5132
Add ConnectorBuilder::with_provider_and_platform_verifierYou can trigger a rebase of this PR by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)