Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump hyper-rustls from 0.25.0 to 0.27.3 #1110

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

Bump hyper-rustls from 0.25.0 to 0.27.3 #1110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
aeb7d64
Bump hyper-rustls from 0.25.0 to 0.27.3
dependabot[bot] Sep 26, 2024
b558b82
Bump hyper-rustls from 0.25.0 to 0.27.3
dependabot[bot] Sep 26, 2024
488fb8a
update rustls and tokio-rustls as well
ahl Sep 26, 2024
935a362
Merge branch 'dependabot/cargo/hyper-rustls-0.27.3' of github.com:oxi…
ahl Sep 26, 2024
84c4293
lock
ahl Sep 26, 2024
700b26d
avoid pulling in aws-lc-rs by disabling rustls features
ahl Sep 27, 2024
d0eb686
be delicate with features
ahl Sep 27, 2024
9382813
add deps in test; allow dropshot consumers to choose flags for rustls
ahl Sep 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
98 changes: 20 additions & 78 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions dropshot/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ indexmap = "2.5.0"
multer = "3.1.0"
paste = "1.0.15"
percent-encoding = "2.3.1"
rustls = "0.22.4"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these remove the default dependency on aws-lc-rs... which does not build on illumos

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a comment here explaining why we're disabling this? Whether it's the short-term reason that aws-lc-rs doesn't build on illumos or a long-term preference to avoid it.

rustls = { version = "0.23.13", default-features = false }
rustls-pemfile = "2.1.3"
scopeguard = "1.2.0"
serde_json = "1.0.128"
Expand All @@ -42,7 +42,7 @@ slog-async = "2.8.0"
slog-bunyan = "2.5.0"
slog-json = "2.6.1"
slog-term = "2.9.1"
tokio-rustls = "0.25.0"
tokio-rustls = { version = "0.26.0", default-features = false }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another comment here maybe?

toml = "0.8.19"
waitgroup = "0.1.2"

Expand Down Expand Up @@ -93,7 +93,7 @@ anyhow = "1.0.89"
async-channel = "2.3.1"
buf-list = "1.0.3"
expectorate = "1.1.0"
hyper-rustls = "0.26.0"
hyper-rustls = { version = "0.27.3", default-features = false, features = ["http1", "ring"] }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this adds what we need for testing across platforms

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another comment here maybe?

hyper-staticfile = "0.10"
lazy_static = "1.5.0"
libc = "0.2.159"
Expand Down
Loading