Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

imageHeight attribute sets the width and aspect ratio is not conserved. #86

Open
LudvigHz opened this issue Jun 19, 2019 · 2 comments
Open

imageHeight attribute sets the width and aspect ratio is not conserved. #86

LudvigHz opened this issue Jun 19, 2019 · 2 comments

Comments

@LudvigHz
Copy link

I am trying to change the imageHeight of some images, and can properly change the width. However the height seems to stay static, Whether I set the width manually or omit the attribute. (The aspect ratio changes when I only set one attribute)
Setting just the ImageHeight Seems to change the width for some reason...

On gnome-shell 3.32.1
@real-or-random
Copy link

I can confirm this.

real-or-random added a commit to real-or-random/argos that referenced this issue Jan 3, 2020
@real-or-random
Improve image sizing
e3016f6 
 - Load icon with the desired height. This fixes p-e-w#86. 
 - Add support for display scaling. This is not perfect because we currently don't redraw on changes.
@real-or-random real-or-random mentioned this issue Jan 3, 2020
Closed
@real-or-random
Copy link

Seems to be fixed on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve image sizing real-or-random/argos
2 participants
@real-or-random @LudvigHz