Improve image sizing

[real-or-random]

• Load icon with the desired height. This fixes imageHeight attribute sets the width and aspect ratio is not conserved. #86.
• Add support for display scaling. This is not perfect because we currently don't redraw on changes.

[real-or-random]

I'm not entirely sure why set_size does not really what we want but this is way to get around the issue.

[p-e-w]

Thanks for the PR, but without a clear understanding of what is actually going on here I am reluctant to merge this. Obviously, I had tested these parameters, and they were working with a previous GNOME Shell version. Therefore, this appears to be yet another API break somehow.

At minimum, I would need someone else to confirm that this really fixes the bug, and does not introduce any new ones.

[real-or-random]

Fwiw, I'm my version is 3.34.3 and I've been using this without any issues so far.

@p-e-w Maybe that's not enough for merging this but can you test this PR on "your" GNOME Shell version where you had tested the old code and see if breaks there? If not, that's already a good indicator that this works across multiple versions.

[p-e-w]

can you test this PR on "your" GNOME Shell version

I don't use GNOME Shell anymore. I switched to Sway a while ago and have not looked back since. Therefore, Argos is in maintenance mode as far as I'm concerned. It would be good if someone else could confirm this works so I don't have to spin up a VM just for this purpose.

[real-or-random]

Okay, I see. Do you think it makes sense to add a big "maintenance mode" notice to the README? Maybe it's possible to find a maintainer.

[ElijahLynn]

I don't use GNOME Shell anymore. I switched to Sway a while ago and have not looked back since. Therefore, Argos is in maintenance mode as far as I'm concerned.

Do you think it makes sense to add a big "maintenance mode" notice to the README? Maybe it's possible to find a maintainer.

Thanks, I opened an issue to discuss the future of argos in #108.

[t-moennich]

I can confirm this is also working for gnome-shell 3.36 and 3.36.1

[real-or-random]

This still works on the current GNOME Shell 42.3.1. The same code is used https://gitlab.gnome.org/GNOME/gnome-shell/-/blob/main/js/gdm/loginDialog.js.

Can we get this merged?

[mwilck]

I am not seeing issues here. Can you provide a sample script that demonstrates the issue?

[real-or-random]

Ha, I can't reproduce the issues on master. I assume the issue was caused by some more fundamental incompatibility with a GNOME update and is resolved now. Maybe I was running master already when I wrote that comment in Aug 2022...

There's one more minor issue that I encountered when testing this. I'll open a separate issue for this.