Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Wrap ffi call > setup verifier methods #660

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

refactor: Wrap ffi call > setup verifier methods #660

wants to merge 1 commit into from
+597 −111

Conversation

tienvx
Copy link
Contributor

@tienvx tienvx commented Sep 28, 2024 •
edited
Loading

Related to #644

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11081085708

Details

  • 101 of 110 (91.82%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 96.196%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/PhpPact/Standalone/ProviderVerifier/Verifier.php 25 27 92.59%
src/PhpPact/FFI/Client.php 76 83 91.57%
Totals Coverage Status
Change from base Build 11071313272: -0.2%
Covered Lines: 2554
Relevant Lines: 2655
💛 - Coveralls

@tienvx tienvx mentioned this pull request Sep 28, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YOU54F YOU54F YOU54F approved these changes

@JP-Ellis JP-Ellis Awaiting requested review from JP-Ellis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tienvx @coveralls @YOU54F