Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap ffi call remaining methods #661

Merged
merged 2 commits into from
Sep 30, 2024
Merged

Wrap ffi call remaining methods #661

merged 2 commits into from
Sep 30, 2024

Conversation

tienvx
Copy link
Contributor

@tienvx tienvx commented Sep 28, 2024

Related to #644

Depend on #660

@coveralls
Copy link

coveralls commented Sep 28, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11100391181

Details

  • 39 of 48 (81.25%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.3%) to 95.921%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/PhpPact/Consumer/Driver/InteractionPart/AbstractInteractionPartDriver.php 2 3 66.67%
src/PhpPact/Consumer/Driver/InteractionPart/RequestDriver.php 4 6 66.67%
src/PhpPact/FFI/Client.php 30 36 83.33%
Totals Coverage Status
Change from base Build 11100376904: -0.3%
Covered Lines: 2587
Relevant Lines: 2697
💛 - Coveralls

@tienvx tienvx mentioned this pull request Sep 28, 2024
Merged
@tienvx tienvx merged commit 2d04e8e into pact-foundation:master Sep 30, 2024
18 checks passed
@tienvx tienvx deleted the wrap-ffi-call-remaining-methods branch September 30, 2024 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YOU54F YOU54F YOU54F approved these changes

@JP-Ellis JP-Ellis JP-Ellis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tienvx @coveralls @JP-Ellis @YOU54F